Skip to content

Commit d057ffb

Browse files
committed
Dispose OverlayEntry in WidgetsApp.router semantics tree structure test
In #192601, the 'WidgetsApp.router produces expected semantics tree structure' test added an OverlayEntry with addTearDown(entry.remove), omitting entry.dispose(). This caused Windows framework_tests_widgets_leak_tracking to report 2 undisposed objects (OverlayEntry and ValueNotifier<_OverlayEntryWidgetState?>).
1 parent 12384f9 commit d057ffb

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎packages/flutter/test/widgets/app_test.dart‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,11 @@ void main() {
621621
builder: (BuildContext context) =>
622622
const Text('overlay content', textDirection: TextDirection.ltr),
623623
);
624-
addTearDown(entry.remove);
624+
addTearDown(
625+
() => entry
626+
..remove()
627+
..dispose(),
628+
);
625629
delegate.navigatorKey.currentState!.overlay!.insert(entry);
626630
await tester.pump();
627631

0 commit comments

Comments
 (0)