++

jonahwilliams · jonahwilliams · commit ceafbaae802f · 2025-02-18T15:28:07.000-08:00
diff --git a/engine/src/flutter/impeller/display_list/dl_golden_unittests.cc b/engine/src/flutter/impeller/display_list/dl_golden_unittests.cc
@@ -413,7 +413,7 @@ TEST_P(DlGoldenTest, BaselineHE) {
   int32_t left_max_y = CalculateMaxY(left.get());
   int32_t right_max_y = CalculateMaxY(right.get());
   int32_t y_diff = std::abs(left_max_y - right_max_y);
-  FML_LOG(ERROR) << "y diff: " << y_diff;  //  TEsting.
+  EXPECT_TRUE(y_diff <= 2) << "y diff: " << y_diff;
 }
 
 TEST_P(DlGoldenTest, MaintainsSpace) {
diff --git a/engine/src/flutter/impeller/golden_tests/vulkan_screenshotter.mm b/engine/src/flutter/impeller/golden_tests/vulkan_screenshotter.mm
@@ -76,25 +76,6 @@ CGContextPtr context(
   CGImagePtr image(CGBitmapContextCreateImage(context.get()), &CGImageRelease);
   FML_CHECK(image);
 
-  // TODO(142641): Perform the flip at the blit stage to avoid this slow copy.
-  if (texture->GetYCoordScale() == -1) {
-    CGContextPtr flipped_context(
-        CGBitmapContextCreate(
-            nullptr, texture->GetSize().width, texture->GetSize().height,
-            /*bitsPerComponent=*/8,
-            /*bytesPerRow=*/0, color_space.get(), bitmap_info),
-        &CGContextRelease);
-    CGContextTranslateCTM(flipped_context.get(), 0, texture->GetSize().height);
-    CGContextScaleCTM(flipped_context.get(), 1.0, -1.0);
-    CGContextDrawImage(
-        flipped_context.get(),
-        CGRectMake(0, 0, texture->GetSize().width, texture->GetSize().height),
-        image.get());
-    CGImagePtr flipped_image(CGBitmapContextCreateImage(flipped_context.get()),
-                             &CGImageRelease);
-    image.swap(flipped_image);
-  }
-
   return std::make_unique<MetalScreenshot>(image.release());
 }
 }  // namespace

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ TEST_P(DlGoldenTest, BaselineHE) {`
`413`	`413`	`int32_t left_max_y = CalculateMaxY(left.get());`
`414`	`414`	`int32_t right_max_y = CalculateMaxY(right.get());`
`415`	`415`	`int32_t y_diff = std::abs(left_max_y - right_max_y);`
`416`		`- FML_LOG(ERROR) << "y diff: " << y_diff; // TEsting.`
	`416`	`+ EXPECT_TRUE(y_diff <= 2) << "y diff: " << y_diff;`
`417`	`417`	`}`
`418`	`418`
`419`	`419`	`TEST_P(DlGoldenTest, MaintainsSpace) {`