Skip to content

Commit ca3d8c7

Browse files
authored
Include engine/src/flutter/.ci.yaml in quarterly goldctl checklist (#194316)
Follow-up to #193932 (review). [`engine/src/flutter/.ci.yaml`](https://github.com/flutter/flutter/blob/5ba8961b517919e97cd58e404b75dcdcf313017a/engine/src/flutter/.ci.yaml#L65-L69) also pins `goldctl` alongside the root `.ci.yaml`. Mention both in the quarterly `goldctl` update issue checklist so the engine pin doesn't get missed.
1 parent 3454222 commit ca3d8c7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎.github/workflows/quarterly-scheduled-tasks.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
### Checklist
6666
- [ ] Check for the latest `goldctl` git revision (e.g. from [CIPD](https://chrome-infra-packages.appspot.com/p/skia/tools/goldctl) or the [Skia Gold repository](https://skia.googlesource.com/buildbot/+/refs/heads/main/gold-client)).
6767
- [ ] Update `goldctl` in `flutter/flutter`:
68-
- [ ] Update `git_revision` for `goldctl` instances in `.ci.yaml`.
68+
- [ ] Update `git_revision` for `goldctl` instances in `.ci.yaml` and `engine/src/flutter/.ci.yaml`.
6969
- [ ] Validate `.ci.yaml` changes and ensure tests pass.
7070
- [ ] Open PR in `flutter/flutter` to close this issue.
7171
- [ ] Update `goldctl` in `flutter/packages`:

0 commit comments

Comments
 (0)