Skip to content

Commit c83f80b

Browse files
authored
Use super-parameter in two_dimensional_utils (#189957)
Work towards dart-lang/sdk#59226 We are reporting some missed cases of 'use_super_parameters'. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 3656164 commit c83f80b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎packages/flutter/test/widgets/two_dimensional_utils.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,14 +341,14 @@ class SimpleListTableView extends TwoDimensionalScrollView {
341341
super.mainAxis = Axis.vertical,
342342
super.verticalDetails = const ScrollableDetails.vertical(),
343343
super.horizontalDetails = const ScrollableDetails.horizontal(),
344-
required TwoDimensionalChildListDelegate delegate,
344+
required super.delegate,
345345
super.cacheExtent,
346346
super.cacheExtentStyle,
347347
super.diagonalDragBehavior = DiagonalDragBehavior.none,
348348
super.dragStartBehavior = DragStartBehavior.start,
349349
super.keyboardDismissBehavior = ScrollViewKeyboardDismissBehavior.manual,
350350
super.clipBehavior = Clip.hardEdge,
351-
}) : super(delegate: delegate);
351+
});
352352

353353
@override
354354
Widget buildViewport(

0 commit comments

Comments
 (0)