Skip to content

Commit c2b58e1

Browse files
[local_auth] Convert implementation to Kotlin (#12635)
Converts the implementation of the plugin to Kotlin, so that it can be used to dogfood the new async/await support in Pigeon 28 (not added in this PR; this is just to unblock adding that in a later PR). The process was as described [here](#188630 (comment)): - Initial conversion was done using the deterministic Android Studio converter - I did manual cleanup for some small errors that resulted from the auto-converter, as well as improving nullability in general (e.g., generics in Java can't be annotated, so the auto-converted assumes they are all nullable) - I fixed warnings and suggestions flagged by Android Studio - I had Gemini do a local code review focusing on idiomatic Kotlin, and incorporated some of its suggestions to make code more Kotlin-y and less Java-in-Kotlin. Tests will be converted in a follow-up PR, so that we aren't making massive changes to implementation and tests in the same PR, since it's intended to be behavior-neutral. Part of #188630 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent d8aba48 commit c2b58e1

9 files changed

Lines changed: 514 additions & 555 deletions

File tree

‎packages/local_auth/local_auth_android/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.1.0
2+
3+
* Converts the implementation to Kotlin.
4+
15
## 2.0.10
26

37
* Updates pigeon dev_dependency to ^27.3.2 for analyzer 14 compatibility.

‎packages/local_auth/local_auth_android/android/src/main/java/io/flutter/plugins/localauth/AuthenticationHelper.java‎

Lines changed: 0 additions & 241 deletions
This file was deleted.

0 commit comments

Comments
 (0)