Skip to content

Commit c156910

Browse files
authored
[CP-beta] Skip emulator.getEmulators test (#189879) (#189888)
CPs cb34620 to temporarily fix #189876 If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
1 parent c9bf3f3 commit c156910

1 file changed

Lines changed: 15 additions & 9 deletions

File tree

‎packages/flutter_tools/test/commands.shard/hermetic/daemon_test.dart‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import 'package:flutter_tools/src/android/android_workflow.dart';
1414
import 'package:flutter_tools/src/application_package.dart';
1515
import 'package:flutter_tools/src/base/dds.dart';
1616
import 'package:flutter_tools/src/base/logger.dart';
17+
import 'package:flutter_tools/src/base/platform.dart';
1718
import 'package:flutter_tools/src/base/utils.dart';
1819
import 'package:flutter_tools/src/build_info.dart';
1920
import 'package:flutter_tools/src/commands/daemon.dart';
@@ -730,15 +731,20 @@ void main() {
730731
expect(response.data['error'], contains('coldBoot is not a bool'));
731732
});
732733

733-
testUsingContext('emulator.getEmulators should respond with list', () async {
734-
daemon = Daemon(daemonConnection, notifyingLogger: notifyingLogger);
735-
daemonStreams.inputs.add(
736-
DaemonMessage(<String, Object?>{'id': 0, 'method': 'emulator.getEmulators'}),
737-
);
738-
final DaemonMessage response = await daemonStreams.outputs.stream.firstWhere(_notEvent);
739-
expect(response.data['id'], 0);
740-
expect(response.data['result'], isList);
741-
});
734+
testUsingContext(
735+
'emulator.getEmulators should respond with list',
736+
() async {
737+
daemon = Daemon(daemonConnection, notifyingLogger: notifyingLogger);
738+
daemonStreams.inputs.add(
739+
DaemonMessage(<String, Object?>{'id': 0, 'method': 'emulator.getEmulators'}),
740+
);
741+
final DaemonMessage response = await daemonStreams.outputs.stream.firstWhere(_notEvent);
742+
expect(response.data['id'], 0);
743+
expect(response.data['result'], isList);
744+
},
745+
// TODO(vashworth): https://github.com/flutter/flutter/issues/189876
746+
skip: const LocalPlatform().isMacOS,
747+
);
742748

743749
testUsingContext('daemon can send exposeUrl requests to the client', () async {
744750
const originalUrl = 'http://localhost:1234/';

0 commit comments

Comments
 (0)