Repository navigation
Commit b57256e
authored
[web] Unskip 12 passing framework tests in text_test and opacity_test (#193298)
Unskips 12 tests across 2 framework test files
(`packages/flutter/test/widgets/text_test.dart` and
`packages/flutter/test/widgets/opacity_test.dart`) that were previously
skipped on web (`skip: isBrowser`) and now pass on Chrome:
- `packages/flutter/test/widgets/text_test.dart` (11 skips removed):
- Unskips 3 semantics tests (Bidi/`TextSpan` recognizer link semantics
and inline widget semantics) skipped for
#62945.
- Unskips the `Overflow is clipping correctly` test skipped for
#87878.
- Unskips 3 `textWidthBasis` tests (`longestLine`, `textAlign` with
parent alignment, and `longestLine` with loose constraints) skipped for
#44020.
- Unskips 4 `WidgetSpans with no semantic information are elided from
semantics` tests skipped for
#87877.
- `packages/flutter/test/widgets/opacity_test.dart` (1 skip removed):
- Unskips `empty opacity does not crash`, skipped for
#49857 (HTML renderer
`OffsetLayer.toImage`, closed).
The only non-trivial diff is `dart format` reflowing the
`textWidthBasis.longestLine confines the width of the paragraph` test
after its trailing `skip:` argument was removed; the test body is
unchanged.
Related issues:
- #44020
- #49857
- #62945
- #87877
- #87878
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md1 parent d39275d commit b57256e
2 files changed
Lines changed: 44 additions & 50 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
| 187 | + | |
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
970 | 970 | | |
971 | 971 | | |
972 | 972 | | |
973 | | - | |
| 973 | + | |
974 | 974 | | |
975 | 975 | | |
976 | 976 | | |
| |||
1061 | 1061 | | |
1062 | 1062 | | |
1063 | 1063 | | |
1064 | | - | |
| 1064 | + | |
1065 | 1065 | | |
1066 | 1066 | | |
1067 | 1067 | | |
| |||
1132 | 1132 | | |
1133 | 1133 | | |
1134 | 1134 | | |
1135 | | - | |
| 1135 | + | |
1136 | 1136 | | |
1137 | 1137 | | |
1138 | 1138 | | |
| |||
1182 | 1182 | | |
1183 | 1183 | | |
1184 | 1184 | | |
1185 | | - | |
| 1185 | + | |
1186 | 1186 | | |
1187 | 1187 | | |
1188 | 1188 | | |
| |||
1264 | 1264 | | |
1265 | 1265 | | |
1266 | 1266 | | |
1267 | | - | |
| 1267 | + | |
1268 | 1268 | | |
1269 | 1269 | | |
1270 | 1270 | | |
| |||
1314 | 1314 | | |
1315 | 1315 | | |
1316 | 1316 | | |
1317 | | - | |
| 1317 | + | |
1318 | 1318 | | |
1319 | | - | |
1320 | | - | |
1321 | | - | |
1322 | | - | |
1323 | | - | |
1324 | | - | |
1325 | | - | |
1326 | | - | |
1327 | | - | |
1328 | | - | |
1329 | | - | |
1330 | | - | |
1331 | | - | |
1332 | | - | |
1333 | | - | |
1334 | | - | |
1335 | | - | |
1336 | | - | |
1337 | | - | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
1338 | 1333 | | |
1339 | 1334 | | |
1340 | 1335 | | |
1341 | | - | |
| 1336 | + | |
| 1337 | + | |
1342 | 1338 | | |
1343 | | - | |
1344 | | - | |
1345 | | - | |
1346 | | - | |
1347 | | - | |
1348 | | - | |
1349 | | - | |
1350 | | - | |
1351 | | - | |
1352 | | - | |
1353 | | - | |
1354 | | - | |
1355 | | - | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
1356 | 1351 | | |
1357 | | - | |
1358 | | - | |
1359 | | - | |
1360 | | - | |
1361 | | - | |
1362 | | - | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
1363 | 1357 | | |
1364 | 1358 | | |
1365 | 1359 | | |
| |||
1437 | 1431 | | |
1438 | 1432 | | |
1439 | 1433 | | |
1440 | | - | |
| 1434 | + | |
1441 | 1435 | | |
1442 | 1436 | | |
1443 | 1437 | | |
| |||
1491 | 1485 | | |
1492 | 1486 | | |
1493 | 1487 | | |
1494 | | - | |
| 1488 | + | |
1495 | 1489 | | |
1496 | 1490 | | |
1497 | 1491 | | |
| |||
1551 | 1545 | | |
1552 | 1546 | | |
1553 | 1547 | | |
1554 | | - | |
| 1548 | + | |
1555 | 1549 | | |
1556 | 1550 | | |
1557 | 1551 | | |
| |||
1622 | 1616 | | |
1623 | 1617 | | |
1624 | 1618 | | |
1625 | | - | |
| 1619 | + | |
1626 | 1620 | | |
1627 | 1621 | | |
1628 | 1622 | | |
| |||
0 commit comments