Skip to content

Commit ad4b29a

Browse files
flutteractionsbotflutteractionsbot
authored
[CP-stable]Denylists b-series powervr from vulkan (#191903)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? - #181315 - #191457 - #191351 ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick. There are a slew of oddities associated with this GPU, graphical glitches and suboptimal performance. ### Changelog Description: Explain this cherry pick: * In one line that is accessible to most Flutter developers. * That describes the state prior to the fix. * That includes which platforms are impacted. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. [flutter/181315] When using Impeller on Android devices with B-Series PowerVR GPUs, visual oddities and performance drops can be experienced. ### Workaround: Is there a workaround for this issue? No. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? This just reverts us to a preexisting state and sends these devices down a well known path.
1 parent d3b14c8 commit ad4b29a

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ bool DriverInfoVK::IsKnownBadDriver() const {
422422
// https://github.com/flutter/flutter/issues/160866
423423
// https://github.com/flutter/flutter/issues/160804
424424
// https://github.com/flutter/flutter/issues/160406
425-
if (powervr_gpu_.has_value() && powervr_gpu_.value() < PowerVRGPU::kBXE) {
425+
if (powervr_gpu_.has_value() && powervr_gpu_.value() < PowerVRGPU::kCXT) {
426426
return true;
427427
}
428428
return false;

‎engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ TEST(DriverInfoVKTest, PowerVRBSeries) {
299299
})
300300
.Build();
301301

302-
EXPECT_FALSE(context->GetDriverInfo()->IsKnownBadDriver());
302+
EXPECT_TRUE(context->GetDriverInfo()->IsKnownBadDriver());
303303
EXPECT_EQ(context->GetDriverInfo()->GetPowerVRGPUInfo(),
304304
std::optional<PowerVRGPU>(PowerVRGPU::kBXM));
305305
}

0 commit comments

Comments
 (0)