Repository navigation
Commit a4a8ee8
committed
Address gemini-code-assist review on tools/gn
Two style/readability fixes flagged on #187591:
1. Factor out the assignments that are identical in both branches of the
`is_host_build(args)` check (`host_cpu`, `target_cpu`,
`dart_target_arch`). The if/else now only differs in how it sets
`host_os` and `target_os`. Behavior is unchanged --
`get_target_cpu(args)` reads `args.target_os`, not the partially-built
`gn_args` dict, so ordering doesn't matter.
2. Wrap the new `--host-cpu` argparse help string to fit the
80-character line limit from the Google Python Style Guide
(referenced by Flutter's `.gemini/styleguide.md`).
No functional change.1 parent ad6f0a0 commit a4a8ee8
1 file changed
Lines changed: 6 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
520 | 520 | | |
521 | 521 | | |
522 | 522 | | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
523 | 526 | | |
524 | 527 | | |
525 | | - | |
526 | 528 | | |
527 | | - | |
528 | | - | |
529 | 529 | | |
530 | | - | |
531 | 530 | | |
532 | | - | |
533 | | - | |
534 | 531 | | |
535 | 532 | | |
536 | 533 | | |
| |||
991 | 988 | | |
992 | 989 | | |
993 | 990 | | |
994 | | - | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
995 | 994 | | |
996 | 995 | | |
997 | 996 | | |
| |||
0 commit comments