Repository navigation
Commit a4896ba
authored
[web] Drop stale composing range after text is replaced mid-composition (#194096)
Fixes #189056
Fixes #193847
Fixes #183078
Fixes #138136
## Problem
On web, pressing a dead key in a `TextField` whose input formatter
rejects the composing character throws "Range end N is out of text of
length M" and leaves editing in a broken state. When the framework
writes the formatted text back to the DOM mid-composition, Chrome drops
the composition without firing `compositionend`. The engine keeps its
cached composing base and text, so the next `selectionchange` reports a
composing range past the end of the text.
## Fix
`DefaultTextEditingStrategy.setEditingState` now forgets the cached
composition when the framework writes different text, which is exactly
when Chrome ends the composition silently. Writing unchanged text keeps
the composition, so normal IME input is unaffected. `disable()` also
clears it, since a composition can no longer be observed ending once the
listeners are removed; this stops a stale range carrying over to the
next text field, which also happens on master.
## Demo
Before: https://flutter-demo-76-before.web.app/
After: https://flutter-demo-76-after.web.app/
1. Open the page in Chrome with the DevTools console open.
2. Click the text field and type `AAA`.
3. Press the circumflex dead key: Option+I on a Mac U.S. layout, or `^`
on French AZERTY.
4. Press Shift+A.
Before: the console shows "Range end 4 is out of text of length 3" and
editing state breaks.
After: the formatter rejects `ˆ` and `Â`, no assertion is thrown, and
typing continues normally.1 parent bd24e53 commit a4896ba
3 files changed
Lines changed: 151 additions & 5 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine/text_editing
- test/engine
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
65 | 67 | | |
66 | 68 | | |
67 | | - | |
| 69 | + | |
68 | 70 | | |
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| 74 | + | |
| 75 | + | |
72 | 76 | | |
73 | 77 | | |
74 | 78 | | |
75 | 79 | | |
76 | 80 | | |
77 | 81 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1773 | 1773 | | |
1774 | 1774 | | |
1775 | 1775 | | |
| 1776 | + | |
1776 | 1777 | | |
1777 | 1778 | | |
1778 | 1779 | | |
1779 | 1780 | | |
| 1781 | + | |
| 1782 | + | |
| 1783 | + | |
| 1784 | + | |
| 1785 | + | |
| 1786 | + | |
| 1787 | + | |
1780 | 1788 | | |
1781 | 1789 | | |
1782 | 1790 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
297 | 434 | | |
298 | 435 | | |
299 | 436 | | |
| |||
0 commit comments