Repository navigation
Commit a0378ad
authored
[CP-beta]Eliminate some early returns in uber_sdf.frag to fix broken UberSDF AA on Windows (#190378)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
### Issue Link:
What is the link to the issue this cherry-pick is addressing?
#189827
### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
This PR fixes anti-aliasing on some draw calls in Impeller Windows, specifically all draws using UberSDF (almost all draws except for paths and some corner case shapes).
### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.
< Replace with changelog description here >
[flutter/189827] When running an app on Windows with Impeller, most raw shape draws had jagged edges.
### Workaround:
Is there a workaround for this issue?
Yes, downgrading to Skia.
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
What are the steps to validate that this fix works?
Verified by running a Flutter app on Windows before and after this fix. See the PR description at #190260.1 parent c7926ac commit a0378ad
2 files changed
Lines changed: 58 additions & 44 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| 179 | + | |
179 | 180 | | |
180 | 181 | | |
181 | | - | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
182 | 187 | | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
| 188 | + | |
187 | 189 | | |
188 | 190 | | |
189 | 191 | | |
| |||
195 | 197 | | |
196 | 198 | | |
197 | 199 | | |
| 200 | + | |
198 | 201 | | |
199 | 202 | | |
| 203 | + | |
200 | 204 | | |
201 | 205 | | |
202 | 206 | | |
203 | | - | |
| 207 | + | |
204 | 208 | | |
205 | 209 | | |
| 210 | + | |
206 | 211 | | |
207 | | - | |
208 | 212 | | |
209 | | - | |
| 213 | + | |
| 214 | + | |
210 | 215 | | |
211 | 216 | | |
212 | 217 | | |
213 | 218 | | |
214 | 219 | | |
215 | 220 | | |
| 221 | + | |
216 | 222 | | |
217 | | - | |
| 223 | + | |
218 | 224 | | |
219 | 225 | | |
220 | 226 | | |
| |||
226 | 232 | | |
227 | 233 | | |
228 | 234 | | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
243 | 258 | | |
244 | | - | |
245 | | - | |
| 259 | + | |
246 | 260 | | |
247 | 261 | | |
248 | 262 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8901 | 8901 | | |
8902 | 8902 | | |
8903 | 8903 | | |
8904 | | - | |
| 8904 | + | |
8905 | 8905 | | |
8906 | 8906 | | |
8907 | 8907 | | |
| |||
8912 | 8912 | | |
8913 | 8913 | | |
8914 | 8914 | | |
8915 | | - | |
8916 | | - | |
8917 | | - | |
8918 | | - | |
| 8915 | + | |
| 8916 | + | |
| 8917 | + | |
| 8918 | + | |
8919 | 8919 | | |
8920 | 8920 | | |
8921 | 8921 | | |
8922 | 8922 | | |
8923 | 8923 | | |
8924 | 8924 | | |
8925 | 8925 | | |
8926 | | - | |
| 8926 | + | |
8927 | 8927 | | |
8928 | 8928 | | |
8929 | 8929 | | |
8930 | 8930 | | |
8931 | 8931 | | |
8932 | 8932 | | |
8933 | 8933 | | |
8934 | | - | |
| 8934 | + | |
8935 | 8935 | | |
8936 | 8936 | | |
8937 | 8937 | | |
| |||
8941 | 8941 | | |
8942 | 8942 | | |
8943 | 8943 | | |
8944 | | - | |
| 8944 | + | |
8945 | 8945 | | |
8946 | 8946 | | |
8947 | 8947 | | |
| |||
8962 | 8962 | | |
8963 | 8963 | | |
8964 | 8964 | | |
8965 | | - | |
| 8965 | + | |
8966 | 8966 | | |
8967 | | - | |
| 8967 | + | |
8968 | 8968 | | |
8969 | 8969 | | |
8970 | 8970 | | |
8971 | | - | |
| 8971 | + | |
8972 | 8972 | | |
8973 | 8973 | | |
8974 | 8974 | | |
| |||
12277 | 12277 | | |
12278 | 12278 | | |
12279 | 12279 | | |
12280 | | - | |
| 12280 | + | |
12281 | 12281 | | |
12282 | 12282 | | |
12283 | 12283 | | |
| |||
12287 | 12287 | | |
12288 | 12288 | | |
12289 | 12289 | | |
12290 | | - | |
| 12290 | + | |
12291 | 12291 | | |
12292 | 12292 | | |
12293 | 12293 | | |
| |||
12309 | 12309 | | |
12310 | 12310 | | |
12311 | 12311 | | |
12312 | | - | |
| 12312 | + | |
12313 | 12313 | | |
12314 | 12314 | | |
12315 | 12315 | | |
| |||
12320 | 12320 | | |
12321 | 12321 | | |
12322 | 12322 | | |
12323 | | - | |
12324 | | - | |
12325 | | - | |
12326 | | - | |
| 12323 | + | |
| 12324 | + | |
| 12325 | + | |
| 12326 | + | |
12327 | 12327 | | |
12328 | 12328 | | |
12329 | 12329 | | |
12330 | 12330 | | |
12331 | 12331 | | |
12332 | 12332 | | |
12333 | 12333 | | |
12334 | | - | |
| 12334 | + | |
12335 | 12335 | | |
12336 | 12336 | | |
12337 | 12337 | | |
| |||
0 commit comments