You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 93b1fcb
Browse filesBrowse the repository at this point in the historyBrowse files
[beta] [flutter_tools] Resolve includes recursively in AnalysisOptionsMigration (#191531)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
### Issue Link:
#191056
### Impact Description:
`AnalysisOptionsMigration` ignored `include:` directives in `analysis_options.yaml` files, causing `flutter pub get` and build commands to repeatedly rewrite `analysis_options.yaml` files that already inherited the required analyzer `exclude:` patterns (such as `build/**`, `android/**`, `ios/**`) via relative or `package:` includes.
### Changelog Description:
[flutter/191056] Recursively resolve includes in AnalysisOptionsMigration to prevent redundant rewrites of analysis_options.yaml.
### Workaround:
Explicitly duplicate exclude patterns in the top-level `analysis_options.yaml` file instead of relying on included configs.
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
1. Create a Flutter project whose `analysis_options.yaml` includes another options file defining platform exclusions.
2. Run `flutter pub get`.
3. Confirm that `analysis_options.yaml` is not unnecessarily modified.
4. Run `packages/flutter_tools/test/general.shard/analysis_options_migration_test.dart`.
0 commit comments