Repository navigation
Commit 8f5e9b0
authored
[Linux] Make glBlitFramebuffer optional in the OpenGL compositor (#189476)
glBlitFramebuffer is a GLES3 / OpenGL 3.0 function and is not guaranteed
to be present, so the Linux embedder should treat it as optional. The
compositor was calling it unconditionally to blit the first layer, which
breaks on OpenGL 2.0 drivers without the GL_EXT_framebuffer_blit
extension and on drivers with a broken implementation (NVIDIA, Vivante,
ARM per #152099).
Restore the blit-availability detection (GL version >= 3.0 or the
GL_EXT_framebuffer_blit extension, plus the driver blacklist) and fall
back to shader-based compositing for the first layer when blit is
unavailable.
This regressed in e983e59 ("Perform
OpenGL compositing in the Flutter thread and write to a framebuffer."
#172090), which consolidated compositing and dropped the
has_gl_framebuffer_blit check.
Strengthen the NoBlitFramebuffer and BlitFramebufferNvidia tests to
assert glBlitFramebuffer is never called.
Fixes #1893221 parent a6882e4 commit 8f5e9b0
2 files changed
Lines changed: 67 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
22 | 27 | | |
23 | 28 | | |
24 | 29 | | |
| |||
52 | 57 | | |
53 | 58 | | |
54 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
55 | 95 | | |
56 | 96 | | |
57 | 97 | | |
| |||
61 | 101 | | |
62 | 102 | | |
63 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
64 | 108 | | |
65 | 109 | | |
66 | 110 | | |
| |||
165 | 209 | | |
166 | 210 | | |
167 | 211 | | |
168 | | - | |
169 | | - | |
170 | 212 | | |
171 | | - | |
172 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
173 | 218 | | |
174 | 219 | | |
175 | 220 | | |
176 | 221 | | |
177 | 222 | | |
178 | | - | |
179 | 223 | | |
180 | 224 | | |
181 | 225 | | |
182 | 226 | | |
| 227 | + | |
183 | 228 | | |
184 | 229 | | |
185 | 230 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
| |||
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
| 139 | + | |
| 140 | + | |
138 | 141 | | |
139 | 142 | | |
140 | 143 | | |
| |||
186 | 189 | | |
187 | 190 | | |
188 | 191 | | |
| 192 | + | |
| 193 | + | |
189 | 194 | | |
190 | 195 | | |
191 | 196 | | |
| |||
230 | 235 | | |
231 | 236 | | |
232 | 237 | | |
| 238 | + | |
| 239 | + | |
233 | 240 | | |
234 | 241 | | |
235 | 242 | | |
| |||
267 | 274 | | |
268 | 275 | | |
269 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
270 | 281 | | |
271 | 282 | | |
272 | 283 | | |
| |||
305 | 316 | | |
306 | 317 | | |
307 | 318 | | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
308 | 323 | | |
309 | 324 | | |
310 | 325 | | |
| |||
335 | 350 | | |
336 | 351 | | |
337 | 352 | | |
| 353 | + | |
338 | 354 | | |
339 | 355 | | |
340 | 356 | | |
| |||
0 commit comments