[Impeller] Use the canonical texture creation failure message

bdero · bdero · commit 8c5aebbca88f · 2026-05-26T16:04:08.000-07:00
The Flutter GPU Texture constructor now throws 'Texture creation failed', matching GpuContext.createTexture and the gpu_test.dart expectation, instead of a divergent message. The now-redundant isValid check in createTexture is removed since the constructor throws on failure.
diff --git a/engine/src/flutter/lib/gpu/lib/src/context.dart b/engine/src/flutter/lib/gpu/lib/src/context.dart
@@ -158,9 +158,7 @@ base class GpuContext extends NativeFieldWrapperClass1 {
       enableShaderWriteUsage,
       mipLevelCount,
     );
-    if (!result.isValid) {
-      throw Exception('Texture creation failed');
-    }
+    // `Texture._initialize` throws on failure, so `result` is always valid here.
     return result;
   }
 
diff --git a/engine/src/flutter/lib/gpu/lib/src/texture.dart b/engine/src/flutter/lib/gpu/lib/src/texture.dart
@@ -68,7 +68,7 @@ base class Texture extends NativeFieldWrapperClass1 {
     if (!_valid) {
       // The engine logs the specific reason (for example, a compressed format
       // used with render target or shader write usage, which is sample-only).
-      throw Exception('Failed to create texture.');
+      throw Exception('Texture creation failed');
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ base class Texture extends NativeFieldWrapperClass1 {`
`68`	`68`	`if (!_valid) {`
`69`	`69`	`// The engine logs the specific reason (for example, a compressed format`
`70`	`70`	`// used with render target or shader write usage, which is sample-only).`
`71`		`- throw Exception('Failed to create texture.');`
	`71`	`+ throw Exception('Texture creation failed');`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`