Fix platform views channel regression (#9185)

amirh · web-flow · commit 86aa01442b5d · 2019-06-04T12:38:38.000-07:00
This regression was introduced in #7847. The PlatformViewsChannel method call handler was always setting the result to `notImplemented` even after handling a result, this resulted in a "Reply already submitted" exception being thrown. Note that the method channel code is swallowing this exception and logging an error, so we didn't crash instead we were logging an error(this is why the integration test didn't fail). Filed #33863 to make sure tests fail when such exceptions are thrown. This PR also cleans up an unused `NoSuchPlatformViewException` that was introduced in #7847. #33866
diff --git a/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java b/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java
@@ -51,8 +51,9 @@ public void onMethodCall(MethodCall call, MethodChannel.Result result) {
         case "setDirection":
           setDirection(call, result);
           break;
+        default:
+          result.notImplemented();
       }
-      result.notImplemented();
     }
 
     private void create(MethodCall call, MethodChannel.Result result) {
@@ -429,9 +430,4 @@ public static class PlatformViewTouch {
       this.flags = flags;
     }
   }
-
-  /**
-   * The provided platform view ID does not correspond to any existing platform view.
-   */
-  public static class NoSuchPlatformViewException extends IllegalStateException {}
 }

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,9 @@ public void onMethodCall(MethodCall call, MethodChannel.Result result) {`
`51`	`51`	`case "setDirection":`
`52`	`52`	`setDirection(call, result);`
`53`	`53`	`break;`
	`54`	`+ default:`
	`55`	`+ result.notImplemented();`
`54`	`56`	`}`
`55`		`- result.notImplemented();`
`56`	`57`	`}`
`57`	`58`
`58`	`59`	`private void create(MethodCall call, MethodChannel.Result result) {`
`@@ -429,9 +430,4 @@ public static class PlatformViewTouch {`
`429`	`430`	`this.flags = flags;`
`430`	`431`	`}`
`431`	`432`	`}`
`432`		`-`
`433`		`- /**`
`434`		`- * The provided platform view ID does not correspond to any existing platform view.`
`435`		`- */`
`436`		`- public static class NoSuchPlatformViewException extends IllegalStateException {}`
`437`	`433`	`}`