Repository navigation
Commit 7e5f105
authored
[Impeller] Fix perspective clips with a large perspective bias (#181434)
Fixes: #173104
We were precomputing the perspective adjustment inside the clipping
vertex shader, which prevented the GPU from performing correct clipping
against the camera plane.1 parent 8eb2fac commit 7e5f105
4 files changed
Lines changed: 77 additions & 27 deletions
File tree
- engine/src/flutter/impeller
- display_list
- entity
- geometry
- shaders
- tools
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2237 | 2237 | | |
2238 | 2238 | | |
2239 | 2239 | | |
| 2240 | + | |
| 2241 | + | |
| 2242 | + | |
| 2243 | + | |
| 2244 | + | |
| 2245 | + | |
| 2246 | + | |
| 2247 | + | |
| 2248 | + | |
| 2249 | + | |
| 2250 | + | |
| 2251 | + | |
| 2252 | + | |
| 2253 | + | |
| 2254 | + | |
| 2255 | + | |
| 2256 | + | |
| 2257 | + | |
| 2258 | + | |
| 2259 | + | |
| 2260 | + | |
| 2261 | + | |
| 2262 | + | |
| 2263 | + | |
| 2264 | + | |
| 2265 | + | |
| 2266 | + | |
| 2267 | + | |
| 2268 | + | |
| 2269 | + | |
| 2270 | + | |
| 2271 | + | |
| 2272 | + | |
| 2273 | + | |
| 2274 | + | |
| 2275 | + | |
| 2276 | + | |
| 2277 | + | |
| 2278 | + | |
| 2279 | + | |
| 2280 | + | |
| 2281 | + | |
| 2282 | + | |
| 2283 | + | |
| 2284 | + | |
| 2285 | + | |
| 2286 | + | |
| 2287 | + | |
| 2288 | + | |
| 2289 | + | |
| 2290 | + | |
2240 | 2291 | | |
2241 | 2292 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
22 | 21 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
530 | 530 | | |
531 | 531 | | |
532 | 532 | | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
537 | 537 | | |
538 | 538 | | |
539 | 539 | | |
| |||
549 | 549 | | |
550 | 550 | | |
551 | 551 | | |
552 | | - | |
553 | | - | |
554 | | - | |
555 | | - | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
556 | 556 | | |
557 | 557 | | |
558 | 558 | | |
559 | 559 | | |
560 | 560 | | |
561 | 561 | | |
562 | 562 | | |
563 | | - | |
564 | | - | |
565 | | - | |
566 | | - | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
567 | 567 | | |
568 | 568 | | |
569 | 569 | | |
| |||
2577 | 2577 | | |
2578 | 2578 | | |
2579 | 2579 | | |
2580 | | - | |
2581 | | - | |
| 2580 | + | |
| 2581 | + | |
| 2582 | + | |
2582 | 2583 | | |
2583 | | - | |
2584 | 2584 | | |
2585 | 2585 | | |
2586 | 2586 | | |
| |||
2596 | 2596 | | |
2597 | 2597 | | |
2598 | 2598 | | |
2599 | | - | |
2600 | | - | |
| 2599 | + | |
| 2600 | + | |
| 2601 | + | |
2601 | 2602 | | |
2602 | | - | |
2603 | 2603 | | |
2604 | 2604 | | |
2605 | 2605 | | |
2606 | 2606 | | |
2607 | 2607 | | |
2608 | 2608 | | |
2609 | 2609 | | |
2610 | | - | |
2611 | | - | |
| 2610 | + | |
| 2611 | + | |
| 2612 | + | |
2612 | 2613 | | |
2613 | | - | |
2614 | 2614 | | |
2615 | 2615 | | |
2616 | 2616 | | |
| |||
0 commit comments