Skip to content

Commit 798ac29

Browse files
Address review: take ApplicationVariant in configureApplicationOutputs
Branch on the variant type at the call site so the function receives an ApplicationVariant and needs no check().
1 parent d8f869e commit 798ac29

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

‎packages/flutter_tools/gradle/src/main/kotlin/FlutterPlugin.kt‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ class FlutterPlugin : Plugin<Project> {
337337
)
338338
registerFlutterAssetTasks(projectToAddTasksTo, variant, compileTaskProvider)
339339
registerFlutterJniLibsTask(projectToAddTasksTo, variant, compileTaskProvider, targetPlatforms)
340-
if (isApplicationProject) {
340+
if (variant is ApplicationVariant) {
341341
configureApplicationOutputs(
342342
projectToAddTasksTo,
343343
variant,
@@ -641,18 +641,14 @@ class FlutterPlugin : Plugin<Project> {
641641
}
642642

643643
/**
644-
* Configures the per-ABI versionCodes and the copy into `build/outputs/flutter-apk/`. Both
645-
* act on APK outputs, which library variants don't have.
644+
* Configures the per-ABI versionCodes of [variant] and the copy of its APKs into
645+
* `build/outputs/flutter-apk/`.
646646
*/
647647
private fun configureApplicationOutputs(
648648
project: Project,
649-
variant: Variant,
649+
variant: ApplicationVariant,
650650
dslVersionCodes: DslVersionCodes
651651
) {
652-
check(variant is ApplicationVariant) {
653-
"Expected an application variant for '${variant.name}' in an application " +
654-
"project, but got ${variant::class.java.name}."
655-
}
656652
configureSplitPerAbiVersionCodes(
657653
project,
658654
variant,

0 commit comments

Comments
 (0)