Repository navigation
Commit 70797e1
authored
[analysis] Upgrade package:analyzer to 14.3.0 and enable custom plugin compilation (#191590)
## Description
Upgrades `package:analyzer` to `14.2.0` and `_fe_analyzer_shared` to
`106.0.0` in the root `pubspec.yaml`, pulling in modern transitive
dependencies (`analysis_server_plugin: 0.3.21`, `analyzer_plugin:
0.14.15`, `dart_style: 3.1.12`, and `analyzer_testing: 0.4.0`).
### Key Changes:
- **Dependency Upgrades**: Bumped `package:analyzer` to `14.2.0` and
updated lockfiles.
- **Update Packages Command**: Added `dev/flutter_analyzer_plugin` to
`_updatePubspec` in
`packages/flutter_tools/lib/src/commands/update_packages.dart` and added
hermetic test coverage in `update_packages_test.dart`.
- **Plugin Migration & Base Class**:
- Introduced `FlutterAnalysisRule` in
`dev/flutter_analyzer_plugin/lib/src/flutter_analysis_rule.dart` which
intercepts `registerNodeProcessors` and automatically skips rule and
visitor registration for read-only Material and Cupertino
implementations and tests.
- Migrated all 17 `dev/flutter_analyzer_plugin` rules to extend
`FlutterAnalysisRule` and implement `registerCustomNodeProcessors`.
- Migrated rules and test fixtures to Analyzer 14 AST patterns and
`package:analyzer_testing`.
- Added unit test suite
`dev/flutter_analyzer_plugin/test/flutter_analysis_rule_test.dart`
verifying path filtering behavior.
- **Rule Scopes & Improvements**:
- `no_sync_async_star`: Restricted to `packages/` and `examples/`,
excluding test files.
- `no_test_imports`: Restricted to `packages/` to avoid flagging runner
helpers.
- `integration_test_timeouts`: Restricted to `dev/` directory.
- `deprecation_syntax`: Excluded `analyze-test-input` fixtures.
- `skip_test_comments`: Expanded ignore scan window across multi-line
argument nodes.
- **Snippets Migration**: Migrated `dev/snippets` AST visitors and mock
filesystem resource provider to Analyzer 14.
- **SDK Compatibility**: Added `dependency_overrides:
analysis_server_plugin: ^0.3.21` to subpackage `analysis_options.yaml`
files to allow isolated plugin runners to resolve on development/master
Dart SDKs that specify unreleased protocol constraints.
- **Linter Fixes**:
- Replaced `scope.catchError` with `scope.then(..., onError: ...)` in
`packages/flutter_tools/lib/src/desktop_device.dart`.
- Added missing `@protected` annotations to non-material public `State`
subtypes in `packages/flutter/lib` (`form.dart`, `raw_tooltip.dart`).
- **CI Tuning**:
- Added heartbeat progress output every 30s during analysis passes in
`dev/bots/analyze.dart` and `dev/devicelab/lib/tasks/analysis.dart`.
- Updated `Linux analyzer_benchmark` in `.ci.yaml` to set `device_type:
none`, routing to 32 GB RAM VM drone bots.
## Tests
- Added unit tests in
`packages/flutter_tools/test/commands.shard/hermetic/update_packages_test.dart`.
- Added unit tests in
`dev/flutter_analyzer_plugin/test/flutter_analysis_rule_test.dart`.
- Ran all 65 unit tests in `dev/flutter_analyzer_plugin` (all pass).
- Ran all 18 unit tests in `dev/snippets` (all pass).
- Ran `flutter analyze --flutter-repo` (0 issues found).1 parent 540a271 commit 70797e1
68 files changed
Lines changed: 550 additions & 216 deletions
File tree
- dev
- bots
- devicelab/lib/tasks
- flutter_analyzer_plugin
- lib
- src
- rules
- test
- package_mixins
- snippets
- lib/src
- test
- tools/test
- examples/layers
- test
- packages
- flutter_driver
- flutter_test
- flutter_tools
- lib/src
- commands
- dart
- packages
- flutter_tools_core
- flutter_tools_extension_linux_prototype
- test
- commands.shard/hermetic
- widget_preview
- integration.shard
- flutter
- lib
- src/widgets
- test
- widgets
- integration_test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| 19 | + | |
| 20 | + | |
18 | 21 | | |
19 | 22 | | |
20 | 23 | | |
| |||
1794 | 1797 | | |
1795 | 1798 | | |
1796 | 1799 | | |
1797 | | - | |
1798 | | - | |
1799 | | - | |
1800 | | - | |
1801 | | - | |
1802 | | - | |
| 1800 | + | |
| 1801 | + | |
| 1802 | + | |
| 1803 | + | |
| 1804 | + | |
| 1805 | + | |
| 1806 | + | |
| 1807 | + | |
| 1808 | + | |
| 1809 | + | |
| 1810 | + | |
| 1811 | + | |
| 1812 | + | |
| 1813 | + | |
1803 | 1814 | | |
1804 | 1815 | | |
1805 | 1816 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
| |||
70 | 73 | | |
71 | 74 | | |
72 | 75 | | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
| 76 | + | |
| 77 | + | |
77 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
78 | 88 | | |
79 | 89 | | |
80 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | 38 | | |
42 | 39 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | 40 | | |
47 | 41 | | |
48 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
31 | | - | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | | - | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
31 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
32 | 38 | | |
33 | 39 | | |
34 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
17 | | - | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
36 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
37 | 44 | | |
38 | 45 | | |
39 | 46 | | |
| |||
48 | 55 | | |
49 | 56 | | |
50 | 57 | | |
51 | | - | |
| 58 | + | |
52 | 59 | | |
53 | 60 | | |
54 | | - | |
55 | 61 | | |
56 | 62 | | |
57 | 63 | | |
| |||
60 | 66 | | |
61 | 67 | | |
62 | 68 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
67 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
68 | 78 | | |
69 | 79 | | |
70 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | | - | |
13 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
| |||
27 | 30 | | |
28 | 31 | | |
29 | 32 | | |
30 | | - | |
31 | | - | |
32 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
33 | 42 | | |
34 | 43 | | |
35 | 44 | | |
| |||
48 | 57 | | |
49 | 58 | | |
50 | 59 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
55 | 64 | | |
56 | 65 | | |
57 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
36 | | - | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
55 | | - | |
56 | | - | |
| 57 | + | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
110 | 112 | | |
111 | 113 | | |
112 | 114 | | |
113 | | - | |
114 | 115 | | |
115 | 116 | | |
116 | 117 | | |
| |||
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
135 | | - | |
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| |||
0 commit comments