You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 63bc5cd
Browse filesBrowse the repository at this point in the historyBrowse files
[google_sign_in] Remove the Objective-C exception catcher (#13156)
Removes the Objective-C `ExceptionCatcher` so `google_sign_in_ios` can be Swift-only. `signIn` / `addScopes` now call the GID SDK directly instead of mapping `NSException` into `PigeonError`.
The SDK only throws for deterministic misconfiguration (missing `GIDClientID`, URL scheme, or client ID). Those fail the same way every time and show up on any login-path test, so keeping a hybrid package to surface them as Dart errors is not worth it. Missing presenter is unchanged: `GIDSignInWrapper` still returns a Dart error without calling the SDK.
Deletes the `google_sign_in_ios_objc` SPM target and the CocoaPods placeholder header. The podspec is Swift-only (`**/*.swift`). Exception-injection tests (`signInExceptionReturnsError`, `addScopesException`) are removed because they would crash without the catcher.
Bumps `google_sign_in_ios` to 6.3.7.
Follow-up to #12658. Fixes#193464
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Copy file name to clipboardExpand all lines: packages/google_sign_in/google_sign_in_ios/CHANGELOG.md
+4Lines changed: 4 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,3 +1,7 @@
1
+
## 6.3.7
2
+
3
+
* Converts the plugin to Swift-only by removing the Objective-C exception catcher. SDK configuration failures now crash natively instead of being reported as Dart errors.
4
+
1
5
## 6.3.6
2
6
3
7
* Converts the Pigeon host API from Objective-C to Swift.
Copy file name to clipboardExpand all lines: packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios/GoogleSignInPlugin.swift
+11-39Lines changed: 11 additions & 39 deletions
Original file line number
Diff line number
Diff line change
@@ -6,10 +6,6 @@ import Darwin
6
6
importFoundation
7
7
importGoogleSignIn
8
8
9
-
#if canImport(google_sign_in_ios_objc)
10
-
importgoogle_sign_in_ios_objc
11
-
#endif
12
-
13
9
#if os(macOS)
14
10
importFlutterMacOS
15
11
#else
@@ -208,20 +204,14 @@ public final class GoogleSignInPlugin: NSObject, FlutterPlugin, GoogleSignInApi
Copy file name to clipboardExpand all lines: packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios_objc/ExceptionCatcher.m
Copy file name to clipboardExpand all lines: packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios_objc/include/google_sign_in_ios/google_sign_in_ios.h
Copy file name to clipboardExpand all lines: packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios_objc/include/google_sign_in_ios_objc/ExceptionCatcher.h
0 commit comments