Skip to content

Commit 63059eb

Browse files
authored
[CP-stable] Skip emulator.getEmulators test (#189879) (#189887)
CPs cb34620 to temporarily fix #189876. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
1 parent e63099b commit 63059eb

1 file changed

Lines changed: 15 additions & 9 deletions

File tree

‎packages/flutter_tools/test/commands.shard/hermetic/daemon_test.dart‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import 'package:flutter_tools/src/android/android_workflow.dart';
1313
import 'package:flutter_tools/src/application_package.dart';
1414
import 'package:flutter_tools/src/base/dds.dart';
1515
import 'package:flutter_tools/src/base/logger.dart';
16+
import 'package:flutter_tools/src/base/platform.dart';
1617
import 'package:flutter_tools/src/base/utils.dart';
1718
import 'package:flutter_tools/src/build_info.dart';
1819
import 'package:flutter_tools/src/commands/daemon.dart';
@@ -749,15 +750,20 @@ void main() {
749750
expect(response.data['error'], contains('coldBoot is not a bool'));
750751
});
751752

752-
testUsingContext('emulator.getEmulators should respond with list', () async {
753-
daemon = Daemon(daemonConnection, notifyingLogger: notifyingLogger);
754-
daemonStreams.inputs.add(
755-
DaemonMessage(<String, Object?>{'id': 0, 'method': 'emulator.getEmulators'}),
756-
);
757-
final DaemonMessage response = await daemonStreams.outputs.stream.firstWhere(_notEvent);
758-
expect(response.data['id'], 0);
759-
expect(response.data['result'], isList);
760-
});
753+
testUsingContext(
754+
'emulator.getEmulators should respond with list',
755+
() async {
756+
daemon = Daemon(daemonConnection, notifyingLogger: notifyingLogger);
757+
daemonStreams.inputs.add(
758+
DaemonMessage(<String, Object?>{'id': 0, 'method': 'emulator.getEmulators'}),
759+
);
760+
final DaemonMessage response = await daemonStreams.outputs.stream.firstWhere(_notEvent);
761+
expect(response.data['id'], 0);
762+
expect(response.data['result'], isList);
763+
},
764+
// TODO(vashworth): https://github.com/flutter/flutter/issues/189876
765+
skip: const LocalPlatform().isMacOS,
766+
);
761767

762768
testUsingContext('daemon can send exposeUrl requests to the client', () async {
763769
const originalUrl = 'http://localhost:1234/';

0 commit comments

Comments
 (0)