Skip to content

Commit 5f811ba

Browse files
committed
Updated skipped tests for painting directory.
1 parent 9664a10 commit 5f811ba

7 files changed

Lines changed: 42 additions & 44 deletions

‎packages/flutter/test/painting/decoration_test.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ void main() {
360360
' The ImageConfiguration was:\n'
361361
' ImageConfiguration(size: Size(100.0, 100.0))\n',
362362
);
363-
}, skip: kIsWeb);
363+
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87364
364364

365365
test('DecorationImage - error listener', () async {
366366
late String exception;
@@ -707,5 +707,5 @@ void main() {
707707
expect(info.image.debugGetOpenHandleStackTraces()!.length, baselineRefCount);
708708

709709
info.dispose();
710-
}, skip: kIsWeb);
710+
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87442
711711
}

‎packages/flutter/test/painting/gradient_test.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -816,15 +816,15 @@ void main() {
816816
for (final Gradient gradient in gradients45) {
817817
testWidgets('$gradient', (WidgetTester tester) async {
818818
await runTest(tester, gradient, 45);
819-
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/41389
819+
});
820820
}
821821
});
822822

823823
group('Gradients - 90 degrees', () {
824824
for (final Gradient gradient in gradients90) {
825825
testWidgets('$gradient', (WidgetTester tester) async {
826826
await runTest(tester, gradient, 90);
827-
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/41389
827+
});
828828
}
829829
});
830830
});

‎packages/flutter/test/painting/image_cache_test.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ void main() {
536536

537537
imageInfo.dispose();
538538
expect(testImage.debugGetOpenHandleStackTraces()!.length, 0);
539-
}, skip: kIsWeb); // Web does not care about image handles.
539+
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87442
540540

541541
test('Image is obtained and disposed of properly for cache when listener is still active', () async {
542542
const int key = 1;
@@ -575,5 +575,5 @@ void main() {
575575
expect(testImage.debugGetOpenHandleStackTraces()!.length, 1);
576576
imageInfo.dispose();
577577
expect(testImage.debugGetOpenHandleStackTraces()!.length, 0);
578-
}, skip: kIsWeb); // Web does not care about open image handles.
578+
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87442
579579
}

‎packages/flutter/test/painting/image_provider_network_image_test.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ void main() {
6969
.having((NetworkImageLoadException e) => e.uri, 'uri', Uri.base.resolve(requestUrl)),
7070
);
7171
expect(httpClient.request.response.drained, true);
72-
}, skip: isBrowser); // Browser implementation does not use HTTP client but an <img> tag.
72+
}, skip: isBrowser); // [intended] Browser implementation does not use HTTP client but an <img> tag.
7373

7474
test('Uses the HttpClient provided by debugNetworkImageHttpClientProvider if set', () async {
7575
httpClient.thrownError = 'client1';
@@ -94,7 +94,7 @@ void main() {
9494
debugNetworkImageHttpClientProvider = () => client2;
9595
await loadNetworkImage();
9696
expect(capturedErrors, <dynamic>['client1', 'client2']);
97-
}, skip: isBrowser); // Browser implementation does not use HTTP client but an <img> tag.
97+
}, skip: isBrowser); // [intended] Browser implementation does not use HTTP client but an <img> tag.
9898

9999
test('Propagates http client errors during resolve()', () async {
100100
httpClient.thrownError = Error();
@@ -155,7 +155,7 @@ void main() {
155155
expect(events[i].cumulativeBytesLoaded, math.min((i + 1) * chunkSize, kTransparentImage.length));
156156
expect(events[i].expectedTotalBytes, kTransparentImage.length);
157157
}
158-
}, skip: isBrowser); // Browser loads images through <img> not Http.
158+
}, skip: isBrowser); // [intended] Browser loads images through <img> not Http.
159159

160160
test('NetworkImage is evicted from cache on SocketException', () async {
161161
final _FakeHttpClient mockHttpClient = _FakeHttpClient();
@@ -187,7 +187,7 @@ void main() {
187187
expect(imageCache!.containsKey(result), isFalse);
188188

189189
debugNetworkImageHttpClientProvider = null;
190-
}, skip: isBrowser); // Browser does not resolve images this way.
190+
}, skip: isBrowser); // [intended] Browser does not resolve images this way.
191191

192192
Future<Codec> _decoder(Uint8List bytes, {int? cacheWidth, int? cacheHeight, bool? allowUpscaling}) async {
193193
return FakeCodec();

‎packages/flutter/test/painting/shader_warm_up_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@ void main() {
5757
throwsA(isA<String>().having((String message) => message, 'message', 'Object has been disposed.')),
5858
);
5959
expect(capturedImage.debugDisposed, true);
60-
}, skip: kIsWeb); // Browser doesn't support approximateBytesUsed and doesn't rasterize the picture at this time.
60+
}, skip: kIsWeb); // [intended] Browser doesn't support approximateBytesUsed and doesn't rasterize the picture at this time.
6161
}

‎packages/flutter/test/painting/text_painter_rtl_test.dart‎

Lines changed: 27 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ void main() {
5151
// to be part of the word sometimes and not others, which is fine, but we'd mildly prefer if
5252
// we were consistently considering them part of words always.
5353
final TextRange hebrew1 = painter.getWordBoundary(const TextPosition(offset: 4, affinity: TextAffinity.downstream));
54-
expect(hebrew1, const TextRange(start: 0, end: 8), skip: skipExpectsWithKnownBugs);
54+
expect(hebrew1, const TextRange(start: 0, end: 8), skip: skipExpectsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
5555
final TextRange english2 = painter.getWordBoundary(const TextPosition(offset: 14, affinity: TextAffinity.downstream));
56-
expect(english2, const TextRange(start: 9, end: 19), skip: skipExpectsWithKnownBugs);
56+
expect(english2, const TextRange(start: 9, end: 19), skip: skipExpectsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
5757
final TextRange hebrew3 = painter.getWordBoundary(const TextPosition(offset: 24, affinity: TextAffinity.downstream));
5858
expect(hebrew3, const TextRange(start: 20, end: 28));
5959

@@ -163,8 +163,8 @@ void main() {
163163
<TextBox>[], // U+202C, non-printing Unicode bidi formatting character
164164
// The list currently has one extra bogus entry (the last entry, for the
165165
// trailing U+202C PDF, should be empty but is one-pixel-wide instead).
166-
], skip: skipExpectsWithKnownBugs);
167-
}, skip: skipTestsWithKnownBugs);
166+
], skip: skipExpectsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
167+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
168168

169169
test('TextPainter - bidi overrides in RTL', () {
170170
final TextPainter painter = TextPainter()
@@ -180,9 +180,9 @@ void main() {
180180
painter.layout();
181181

182182
final TextRange hebrew1 = painter.getWordBoundary(const TextPosition(offset: 4, affinity: TextAffinity.downstream));
183-
expect(hebrew1, const TextRange(start: 0, end: 8), skip: skipExpectsWithKnownBugs);
183+
expect(hebrew1, const TextRange(start: 0, end: 8), skip: skipExpectsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
184184
final TextRange english2 = painter.getWordBoundary(const TextPosition(offset: 14, affinity: TextAffinity.downstream));
185-
expect(english2, const TextRange(start: 9, end: 19), skip: skipExpectsWithKnownBugs);
185+
expect(english2, const TextRange(start: 9, end: 19), skip: skipExpectsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
186186
final TextRange hebrew3 = painter.getWordBoundary(const TextPosition(offset: 24, affinity: TextAffinity.downstream));
187187
expect(hebrew3, const TextRange(start: 20, end: 28));
188188

@@ -253,9 +253,9 @@ void main() {
253253
],
254254
// Horizontal offsets are currently one pixel off in places; vertical offsets are good.
255255
// The list is currently in the wrong order (so selection boxes will paint in the wrong order).
256-
skip: skipExpectsWithKnownBugs,
256+
skip: skipExpectsWithKnownBugs, // https://github.com/flutter/flutter/issues/87536
257257
);
258-
}, skip: skipTestsWithKnownBugs);
258+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
259259

260260
test('TextPainter - forced line-wrapping with bidi', () {
261261
final TextPainter painter = TextPainter()
@@ -353,9 +353,10 @@ void main() {
353353
TextBox.fromLTRBD( 0.0, 20.0, 60.0, 40.0, TextDirection.ltr),
354354
TextBox.fromLTRBD(60.0, 28.0, 110.0, 38.0, TextDirection.ltr),
355355
],
356-
skip: skipExpectsWithKnownBugs, // horizontal offsets are one pixel off in places; vertical offsets are good
356+
// horizontal offsets are one pixel off in places; vertical offsets are good
357+
skip: skipExpectsWithKnownBugs, // https://github.com/flutter/flutter/issues/87536
357358
);
358-
}, skip: skipTestsWithKnownBugs);
359+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
359360

360361
test('TextPainter - line wrap mid-word, bidi - LTR base', () {
361362
final TextPainter painter = TextPainter()
@@ -386,7 +387,8 @@ void main() {
386387
TextBox.fromLTRBD( 0.0, 20.0, 40.0, 40.0, TextDirection.rtl),
387388
TextBox.fromLTRBD(40.0, 28.0, 90.0, 38.0, TextDirection.ltr),
388389
],
389-
skip: skipExpectsWithKnownBugs, // horizontal offsets are one pixel off in places; vertical offsets are good
390+
// horizontal offsets are one pixel off in places; vertical offsets are good
391+
skip: skipExpectsWithKnownBugs, // https://github.com/flutter/flutter/issues/87536
390392
);
391393

392394
final List<List<TextBox>> list = <List<TextBox>>[
@@ -410,7 +412,7 @@ void main() {
410412
<TextBox>[TextBox.fromLTRBD(70.0, 28.0, 80.0, 38.0, TextDirection.ltr)],
411413
<TextBox>[TextBox.fromLTRBD(80.0, 28.0, 90.0, 38.0, TextDirection.ltr)],
412414
]);
413-
}, skip: skipTestsWithKnownBugs);
415+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
414416

415417
test('TextPainter - line wrap mid-word, bidi - RTL base', () {
416418
final TextPainter painter = TextPainter()
@@ -443,9 +445,9 @@ void main() {
443445
],
444446
// Horizontal offsets are currently one pixel off in places; vertical offsets are good.
445447
// The list is currently in the wrong order (so selection boxes will paint in the wrong order).
446-
skip: skipExpectsWithKnownBugs,
448+
skip: skipExpectsWithKnownBugs, // https://github.com/flutter/flutter/issues/87536
447449
);
448-
}, skip: skipTestsWithKnownBugs);
450+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
449451

450452
test('TextPainter - multiple levels', () {
451453
final TextPainter painter = TextPainter()
@@ -474,9 +476,9 @@ void main() {
474476
// Horizontal offsets are currently one pixel off in places; vertical offsets are good.
475477
// The list is currently in the wrong order (so selection boxes will paint in the wrong order).
476478
// Also currently there's an extraneous box at the start of the list.
477-
skip: skipExpectsWithKnownBugs,
479+
skip: skipExpectsWithKnownBugs, // https://github.com/flutter/flutter/issues/87536
478480
);
479-
}, skip: skipTestsWithKnownBugs);
481+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
480482

481483
test('TextPainter - getPositionForOffset - RTL in LTR', () {
482484
final TextPainter painter = TextPainter()
@@ -518,7 +520,8 @@ void main() {
518520
// ^
519521
painter.getPositionForOffset(const Offset(12.0, 5.0)).toString(),
520522
const TextPosition(offset: 1, affinity: TextAffinity.downstream).toString(),
521-
skip: skipExpectsWithKnownBugs, // currently we say upstream instead of downstream
523+
// currently we say upstream instead of downstream
524+
skip: skipExpectsWithKnownBugs, // https://github.com/flutter/flutter/issues/87536
522525
);
523526
expect(
524527
// Aaa Bbb Ccc Gimel Bet Alef Ddd Eee Fff
@@ -558,7 +561,7 @@ void main() {
558561
painter.getPositionForOffset(const Offset(100.0, 5.0)).toString(),
559562
const TextPosition(offset: 9, affinity: TextAffinity.upstream).toString(),
560563
);
561-
}, skip: skipTestsWithKnownBugs);
564+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
562565

563566
test('TextPainter - getPositionForOffset - LTR in RTL', () {
564567
final TextPainter painter = TextPainter()
@@ -603,7 +606,7 @@ void main() {
603606
painter.getPositionForOffset(const Offset(62.0, 5.0)).toString(),
604607
const TextPosition(offset: 3, affinity: TextAffinity.upstream).toString(),
605608
);
606-
}, skip: skipTestsWithKnownBugs);
609+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
607610

608611
test('TextPainter - Spaces', () {
609612
final TextPainter painter = TextPainter()
@@ -651,7 +654,7 @@ void main() {
651654

652655
expect(painter.width, 410.0);
653656
expect(painter.height, 200.0);
654-
expect(painter.computeDistanceToActualBaseline(TextBaseline.alphabetic), 160.0);
657+
expect(painter.computeDistanceToActualBaseline(TextBaseline.alphabetic), moreOrLessEquals(160.0, epsilon: 0.001));
655658
expect(painter.preferredLineHeight, 100.0);
656659

657660
expect(
@@ -662,9 +665,9 @@ void main() {
662665
TextBox.fromLTRBD(110.0, 0.0, 310.0, 200.0, TextDirection.ltr),
663666
],
664667
// Horizontal offsets are currently one pixel off in places; vertical offsets are good.
665-
skip: skipExpectsWithKnownBugs,
668+
skip: skipExpectsWithKnownBugs, // https://github.com/flutter/flutter/issues/87536
666669
);
667-
}, skip: skipTestsWithKnownBugs);
670+
}, skip: skipTestsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536
668671

669672
test('TextPainter - empty text baseline', () {
670673
final TextPainter painter = TextPainter()
@@ -674,14 +677,9 @@ void main() {
674677
style: TextStyle(fontFamily: 'Ahem', fontSize: 100.0, height: 1.0),
675678
);
676679
painter.layout();
677-
expect(
678-
// Returns -1
679-
painter.computeDistanceToActualBaseline(TextBaseline.alphabetic), 80.0,
680-
skip: skipExpectsWithKnownBugs,
681-
);
682-
}, skip: skipTestsWithKnownBugs);
680+
expect(painter.computeDistanceToActualBaseline(TextBaseline.alphabetic), moreOrLessEquals(80.0, epsilon: 0.001));
681+
});
683682
}
684683

685-
686684
String lro(String s) => '${Unicode.LRO}L${s}L${Unicode.PDF}';
687685
String rlo(String s) => '${Unicode.RLO}R${s}R${Unicode.PDF}';

‎packages/flutter/test/painting/text_painter_test.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ void main() {
746746
expect(painter.inlinePlaceholderBoxes![11], const TextBox.fromLTRBD(250, 30, 300, 60, TextDirection.ltr));
747747
expect(painter.inlinePlaceholderBoxes![12], const TextBox.fromLTRBD(300, 30, 351, 60, TextDirection.ltr));
748748
expect(painter.inlinePlaceholderBoxes![13], const TextBox.fromLTRBD(351, 30, 401, 60, TextDirection.ltr));
749-
}, skip: isBrowser && !isCanvasKit); // https://github.com/flutter/flutter/issues/42086
749+
}, skip: isBrowser && !isCanvasKit); // https://github.com/flutter/flutter/issues/87540
750750

751751
// Null values are valid. See https://github.com/flutter/flutter/pull/48346#issuecomment-584839221
752752
test('TextPainter set TextHeightBehavior null test', () {
@@ -955,7 +955,7 @@ void main() {
955955
).first.toRect();
956956
expect(glyphBox, newGlyphBox);
957957
});
958-
}, skip: isBrowser && !isCanvasKit);
958+
}, skip: isBrowser && !isCanvasKit); // https://github.com/flutter/flutter/issues/87543
959959

960960
test('TextPainter handles invalid UTF-16', () {
961961
Object? exception;
@@ -973,7 +973,7 @@ void main() {
973973
// The layout should include one replacement character.
974974
expect(painter.width, equals(fontSize));
975975
expect(exception, isNotNull);
976-
}, skip: kIsWeb);
976+
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87544
977977

978978
test('Diacritic', () {
979979
final TextPainter painter = TextPainter()
@@ -989,7 +989,7 @@ void main() {
989989
offset: text.length, affinity: TextAffinity.upstream),
990990
ui.Rect.zero);
991991
expect(caretOffset.dx, painter.width);
992-
}, skip: kIsWeb && !isCanvasKit);
992+
}, skip: kIsWeb && !isCanvasKit); // https://github.com/flutter/flutter/issues/87545
993993
}
994994

995995
class MockCanvas extends Fake implements Canvas {

0 commit comments

Comments
 (0)