Repository navigation
Commit 5c1670f
committed
[web] End the autofill fill window when any field of the form gets focus
A password manager's menu taking the focus from the active field opens
the fill window, which holds the fields still while the manager fills.
The window ended only when that same field, the window or the page got
the focus back. A manager that focuses another field of the form
instead left the window open, so placement updates stayed disabled and
the fields stayed at stale coordinates, for example after a resize.
Every field of the form now ends the fill window when it gets the focus.
A placement that arrives while the window is open is now held by the
form and applied when the window ends, instead of being dropped until
the next layout change. It moves the fields but not the focus, since the
manager may have just focused another field. A form that goes dormant
drops the held placement, as its connection is closing.1 parent dd6e4da commit 5c1670f
2 files changed
Lines changed: 125 additions & 6 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine/text_editing
- test/engine
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
589 | 589 | | |
590 | 590 | | |
591 | 591 | | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
592 | 596 | | |
593 | 597 | | |
594 | 598 | | |
595 | | - | |
596 | | - | |
| 599 | + | |
| 600 | + | |
597 | 601 | | |
598 | 602 | | |
599 | 603 | | |
600 | 604 | | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
601 | 611 | | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
602 | 616 | | |
603 | 617 | | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
604 | 625 | | |
605 | 626 | | |
606 | 627 | | |
| |||
685 | 706 | | |
686 | 707 | | |
687 | 708 | | |
688 | | - | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
689 | 712 | | |
690 | 713 | | |
691 | 714 | | |
| |||
979 | 1002 | | |
980 | 1003 | | |
981 | 1004 | | |
| 1005 | + | |
982 | 1006 | | |
983 | 1007 | | |
984 | 1008 | | |
| |||
1015 | 1039 | | |
1016 | 1040 | | |
1017 | 1041 | | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
1018 | 1049 | | |
1019 | 1050 | | |
1020 | 1051 | | |
| |||
2258 | 2289 | | |
2259 | 2290 | | |
2260 | 2291 | | |
2261 | | - | |
2262 | | - | |
2263 | | - | |
| 2292 | + | |
| 2293 | + | |
| 2294 | + | |
| 2295 | + | |
| 2296 | + | |
2264 | 2297 | | |
2265 | 2298 | | |
2266 | 2299 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3952 | 3952 | | |
3953 | 3953 | | |
3954 | 3954 | | |
| 3955 | + | |
| 3956 | + | |
| 3957 | + | |
| 3958 | + | |
| 3959 | + | |
| 3960 | + | |
| 3961 | + | |
| 3962 | + | |
| 3963 | + | |
| 3964 | + | |
| 3965 | + | |
| 3966 | + | |
| 3967 | + | |
| 3968 | + | |
| 3969 | + | |
| 3970 | + | |
| 3971 | + | |
| 3972 | + | |
| 3973 | + | |
| 3974 | + | |
| 3975 | + | |
| 3976 | + | |
| 3977 | + | |
| 3978 | + | |
| 3979 | + | |
| 3980 | + | |
| 3981 | + | |
| 3982 | + | |
| 3983 | + | |
| 3984 | + | |
| 3985 | + | |
| 3986 | + | |
| 3987 | + | |
| 3988 | + | |
| 3989 | + | |
| 3990 | + | |
| 3991 | + | |
| 3992 | + | |
| 3993 | + | |
| 3994 | + | |
| 3995 | + | |
| 3996 | + | |
| 3997 | + | |
| 3998 | + | |
| 3999 | + | |
| 4000 | + | |
| 4001 | + | |
| 4002 | + | |
| 4003 | + | |
| 4004 | + | |
| 4005 | + | |
| 4006 | + | |
| 4007 | + | |
| 4008 | + | |
| 4009 | + | |
| 4010 | + | |
| 4011 | + | |
| 4012 | + | |
| 4013 | + | |
| 4014 | + | |
| 4015 | + | |
| 4016 | + | |
| 4017 | + | |
| 4018 | + | |
| 4019 | + | |
| 4020 | + | |
| 4021 | + | |
| 4022 | + | |
| 4023 | + | |
| 4024 | + | |
| 4025 | + | |
| 4026 | + | |
| 4027 | + | |
| 4028 | + | |
| 4029 | + | |
| 4030 | + | |
| 4031 | + | |
| 4032 | + | |
| 4033 | + | |
| 4034 | + | |
| 4035 | + | |
| 4036 | + | |
| 4037 | + | |
| 4038 | + | |
| 4039 | + | |
| 4040 | + | |
3955 | 4041 | | |
3956 | 4042 | | |
3957 | 4043 | | |
| |||
0 commit comments