Skip to content

Commit 53c1746

Browse files
authored
Explicitly disable HCPP in hybrid_android_views integration test (#191894)
Fixes the failure in `Linux_mokey hybrid_android_views_integration_test` caused by HCPP being enabled by default in #190623. The `hybrid_android_views` integration test specifically verifies legacy Hybrid Composition view hierarchy behavior and expects `FlutterImageView`s to be present in the view tree. Since HCPP relies on `SurfaceControl` overlays on API 34+ rather than `FlutterImageView`, this test app needs to explicitly opt out of HCPP to continue testing the legacy HC mode as intended.
1 parent e8dca90 commit 53c1746

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎dev/integration_tests/android_engine_test/android/app/src/main/AndroidManifest.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ found in the LICENSE file. -->
3535
<meta-data android:name="flutterEmbedding" android:value="2" />
3636
<meta-data android:name="io.flutter.embedding.android.EnableImpeller" android:value="true" />
3737
<meta-data android:name="io.flutter.embedding.android.ImpellerBackend" android:value="vulkan" />
38-
<!-- Don't delete the meta-data below, even though it matches the platform default.
38+
<!-- Don't delete the meta-data below, even if it matches the platform default.
3939
These tests intentionally exercise explicit platform view modes, and an explicit
4040
value here stops the tool from injecting the enable-hcpp feature flag default. -->
4141
<meta-data android:name="io.flutter.embedding.android.EnableHcpp" android:value="false" />

‎dev/integration_tests/hybrid_android_views/android/app/src/main/AndroidManifest.xml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@ found in the LICENSE file. -->
2525
<meta-data
2626
android:name="flutterEmbedding"
2727
android:value="2" />
28+
<!-- Don't delete the meta-data below, even if it matches the platform default.
29+
These tests intentionally exercise explicit platform view modes, and an explicit
30+
value here stops the tool from injecting the enable-hcpp feature flag default. -->
31+
<meta-data
32+
android:name="io.flutter.embedding.android.EnableHcpp"
33+
android:value="false" />
2834
</application>
2935
<!-- Required to query activities that can process text, see:
3036
https://developer.android.com/training/package-visibility and

0 commit comments

Comments
 (0)