Skip to content

Commit 537c9d1

Browse files
authored
[devicelab] Remove orphaned screenshot test files (#190879)
Remove several orphaned screenshot test files and associated code that were left behind after `package:image` was removed. Files deleted: - `dev/devicelab/bin/tasks/integration_ui_screenshot.dart` - `dev/devicelab/bin/tasks/integration_ui_ios_screenshot.dart` - `dev/integration_tests/ui/lib/screenshot.dart` Code removed: - `createEndToEndScreenshotTest()` in `dev/devicelab/lib/tasks/integration_tests.dart` Also removed corresponding entries from `TESTOWNERS`. Fixes #190696 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with \`///\`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 8837b1f commit 537c9d1

5 files changed

Lines changed: 0 additions & 107 deletions

File tree

‎TESTOWNERS‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@
156156
/dev/devicelab/bin/tasks/integration_ui_driver.dart @bkonyi @flutter/tool
157157
/dev/devicelab/bin/tasks/integration_ui_frame_number.dart @jtmcdole @flutter/engine
158158
/dev/devicelab/bin/tasks/integration_ui_keyboard_resize.dart @bkonyi @flutter/tool
159-
/dev/devicelab/bin/tasks/integration_ui_screenshot.dart @bkonyi @flutter/tool
160159
/dev/devicelab/bin/tasks/integration_ui_textfield.dart @bkonyi @flutter/tool
161160
/dev/devicelab/bin/tasks/microbenchmarks.dart @jtmcdole @flutter/engine
162161
/dev/devicelab/bin/tasks/native_assets_android.dart @dcharkes @flutter/android
@@ -210,7 +209,6 @@
210209
/dev/devicelab/bin/tasks/integration_ui_ios_driver.dart LongCatIsLooong @flutter/tool
211210
/dev/devicelab/bin/tasks/integration_ui_ios_frame_number.dart @jtmcdole @flutter/engine
212211
/dev/devicelab/bin/tasks/integration_ui_ios_keyboard_resize.dart @LongCatIsLooong @flutter/engine
213-
/dev/devicelab/bin/tasks/integration_ui_ios_screenshot.dart @LongCatIsLooong @flutter/tool
214212
/dev/devicelab/bin/tasks/integration_ui_ios_textfield.dart @LongCatIsLooong @flutter/tool
215213
/dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart @hellohuanlin @flutter/tool
216214
/dev/devicelab/bin/tasks/ios_defines_test.dart @vashworth @flutter/tool

‎dev/devicelab/bin/tasks/integration_ui_ios_screenshot.dart‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎dev/devicelab/bin/tasks/integration_ui_screenshot.dart‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎dev/devicelab/lib/tasks/integration_tests.dart‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,6 @@ TaskFunction createEndToEndDriverTest({Map<String, String>? environment}) {
119119
).call;
120120
}
121121

122-
TaskFunction createEndToEndScreenshotTest() {
123-
return DriverTest(
124-
'${flutterDirectory.path}/dev/integration_tests/ui',
125-
'lib/screenshot.dart',
126-
).call;
127-
}
128-
129122
TaskFunction createEndToEndKeyboardTextfieldTest() {
130123
return DriverTest(
131124
'${flutterDirectory.path}/dev/integration_tests/ui',

‎dev/integration_tests/ui/lib/screenshot.dart‎

Lines changed: 0 additions & 74 deletions
This file was deleted.

0 commit comments

Comments
 (0)