Skip to content

Commit 4cf9b62

Browse files
committed
Apply review suggestions to comments
1 parent f50fa68 commit 4cf9b62

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/layout.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,8 @@ class TextLayout {
280280
hardlineClusterRange.isNotEmpty && hardlineClusterRange.end == allClusters.length - 1;
281281
final allTextRange = ui.TextRange(
282282
start: contentTextRange.start,
283-
// Use hardlineTextRange.start rather than whitespaceTextRange.end so unmapped clusterless
284-
// characters following trailing spaces are included in this line's text range.
283+
// Use hardlineTextRange.start rather than whitespaceTextRange.end so clusterless characters
284+
// following trailing spaces are included in this line's text range.
285285
end: includesTrailingNewline ? hardlineTextRange.end : hardlineTextRange.start,
286286
);
287287
// TODO(jlavrova): Should we use a TextLineBuilder pattern instead?

‎engine/src/flutter/lib/web_ui/test/webparagraph/paragraph_edge_cases_test.dart‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,9 +953,9 @@ Future<void> testMain() async {
953953
('right-to-left mark', '\u200F'),
954954
]) {
955955
test('Soft line break before a $name after a zero width space wraps the line', () {
956-
// A soft break opportunity after U+200B (LB8) lands on the immediately following
957-
// directional mark, which has no cluster of its own. Line wrapping must still detect the
958-
// soft break before the next visible cluster.
956+
// Depending on the browser's line breaker, the soft break after U+200B (LB8) can land on
957+
// the following directional mark, which has no cluster of its own. Line wrapping must
958+
// still detect the soft break before the next visible cluster.
959959
final builder = ui.ParagraphBuilder(ahemStyle)..addText('ab\u200B${character}cd');
960960
final ui.Paragraph paragraph = builder.build()
961961
..layout(const ui.ParagraphConstraints(width: 30));

0 commit comments

Comments
 (0)