Skip to content

Commit 468c2c9

Browse files
authored
Clean android engine/embedding tests (#189276)
This change mostly removes unused imports and fixes the linter warnings about asserts <img width="422" height="57" alt="Screenshot 2026-07-10 at 17 47 51" src="https://github.com/user-attachments/assets/dda17237-27d5-4280-b632-9cadf3de12f6" /> <img width="333" height="66" alt="Screenshot 2026-07-10 at 17 36 03" src="https://github.com/user-attachments/assets/18ddae56-7777-4aa9-a5db-12f3b93e0bbf" /> <img width="444" height="440" alt="Screenshot 2026-07-10 at 17 44 57" src="https://github.com/user-attachments/assets/3690f477-c0cf-438e-85c3-03bf0da0fc76" /> <img width="427" height="273" alt="Screenshot 2026-07-10 at 17 34 16" src="https://github.com/user-attachments/assets/3be1122e-a340-470d-beb9-e75785f50344" /> ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent edcf4c8 commit 468c2c9

22 files changed

Lines changed: 182 additions & 186 deletions

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterFragmentActivityTest.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public void tearDown() {
7070
@Test
7171
public void createFlutterFragment_defaultRenderModeSurface() {
7272
final FlutterFragmentActivity activity = new FakeFlutterFragmentActivity();
73-
assertEquals(activity.createFlutterFragment().getRenderMode(), RenderMode.surface);
73+
assertEquals(RenderMode.surface, activity.createFlutterFragment().getRenderMode());
7474
}
7575

7676
@Test
@@ -82,7 +82,7 @@ protected BackgroundMode getBackgroundMode() {
8282
return BackgroundMode.transparent;
8383
}
8484
};
85-
assertEquals(activity.createFlutterFragment().getRenderMode(), RenderMode.texture);
85+
assertEquals(RenderMode.texture, activity.createFlutterFragment().getRenderMode());
8686
}
8787

8888
@Test
@@ -94,7 +94,7 @@ protected RenderMode getRenderMode() {
9494
return RenderMode.texture;
9595
}
9696
};
97-
assertEquals(activity.createFlutterFragment().getRenderMode(), RenderMode.texture);
97+
assertEquals(RenderMode.texture, activity.createFlutterFragment().getRenderMode());
9898
}
9999

100100
@Test
@@ -107,7 +107,7 @@ public String getDartEntrypointLibraryUri() {
107107
}
108108
};
109109
assertEquals(
110-
activity.createFlutterFragment().getDartEntrypointLibraryUri(), "package:foo/bar.dart");
110+
"package:foo/bar.dart", activity.createFlutterFragment().getDartEntrypointLibraryUri());
111111
}
112112

113113
@Test

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/android/KeyChannelResponderTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@ public void primaryResponderTest() {
5353
(canHandleEvent) -> {
5454
completionCallbackInvocationCounter[0]++;
5555
});
56-
assertEquals(completionCallbackInvocationCounter[0], 1);
56+
assertEquals(1, completionCallbackInvocationCounter[0]);
5757
}
5858
}

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/FlutterEngineTest.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static org.junit.Assert.assertEquals;
44
import static org.junit.Assert.assertNotNull;
5+
import static org.junit.Assert.assertNull;
56
import static org.junit.Assert.assertTrue;
67
import static org.mockito.Mockito.any;
78
import static org.mockito.Mockito.anyInt;
@@ -140,10 +141,10 @@ public void itCanBeRetrievedByHandle() {
140141
assertEquals(flutterEngine1, FlutterEngine.engineForId(1));
141142
assertEquals(flutterEngine2, FlutterEngine.engineForId(2));
142143
flutterEngine1.destroy();
143-
assertEquals(null, FlutterEngine.engineForId(1));
144+
assertNull(FlutterEngine.engineForId(1));
144145
assertEquals(flutterEngine2, FlutterEngine.engineForId(2));
145146
flutterEngine2.destroy();
146-
assertEquals(null, FlutterEngine.engineForId(2));
147+
assertNull(FlutterEngine.engineForId(2));
147148
}
148149

149150
// Helps show the root cause of MissingPluginException type errors like

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/dart/DartExecutorTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void itHasReasonableDefaultsWhenFlutterLoaderIsInitialized() {
8383
FlutterInjector.setInstance(
8484
new FlutterInjector.Builder().setFlutterLoader(mockFlutterLoader).build());
8585
DartEntrypoint entrypoint = DartEntrypoint.createDefault();
86-
assertEquals(entrypoint.pathToBundle, "my/custom/path");
87-
assertEquals(entrypoint.dartEntrypointFunctionName, "main");
86+
assertEquals("my/custom/path", entrypoint.pathToBundle);
87+
assertEquals("main", entrypoint.dartEntrypointFunctionName);
8888
}
8989
}

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/dart/DartMessengerTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ public void testSerialTaskQueue() throws InterruptedException {
342342
latch.await();
343343
assertEquals(count, ints.size());
344344
for (int i = 0; i < count - 1; ++i) {
345-
assertEquals((int) ints.get(i), (int) (ints.get(i + 1)) - 1);
345+
assertEquals((int) ints.get(i), ints.get(i + 1) - 1);
346346
}
347347
}
348348
}

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/deferredcomponents/PlayStoreDeferredComponentManagerTest.java‎

Lines changed: 57 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -110,18 +110,18 @@ public void downloadCallsJNIFunctions() throws NameNotFoundException {
110110
TestPlayStoreDeferredComponentManager playStoreManager =
111111
new TestPlayStoreDeferredComponentManager(spyContext, jni);
112112
jni.setDeferredComponentManager(playStoreManager);
113-
assertEquals(jni.loadingUnitId, 0);
113+
assertEquals(0, jni.loadingUnitId);
114114

115115
playStoreManager.installDeferredComponent(123, "TestModuleName");
116-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
117-
assertEquals(jni.updateAssetManagerCalled, 1);
118-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
116+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
117+
assertEquals(1, jni.updateAssetManagerCalled);
118+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
119119

120-
assertEquals(jni.searchPaths[0], soTestFilename);
120+
assertEquals(soTestFilename, jni.searchPaths[0]);
121121
assertTrue(jni.searchPaths[1].endsWith(soTestPath));
122-
assertEquals(jni.searchPaths.length, 2);
123-
assertEquals(jni.loadingUnitId, 123);
124-
assertEquals(jni.assetBundlePath, "flutter_assets");
122+
assertEquals(2, jni.searchPaths.length);
123+
assertEquals(123, jni.loadingUnitId);
124+
assertEquals("flutter_assets", jni.assetBundlePath);
125125
}
126126

127127
@Test
@@ -141,18 +141,18 @@ public void downloadCallsJNIFunctionsWithFilenameFromManifest() throws NameNotFo
141141
TestPlayStoreDeferredComponentManager playStoreManager =
142142
new TestPlayStoreDeferredComponentManager(spyContext, jni);
143143
jni.setDeferredComponentManager(playStoreManager);
144-
assertEquals(jni.loadingUnitId, 0);
144+
assertEquals(0, jni.loadingUnitId);
145145

146146
playStoreManager.installDeferredComponent(123, "TestModuleName");
147-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
148-
assertEquals(jni.updateAssetManagerCalled, 1);
149-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
147+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
148+
assertEquals(1, jni.updateAssetManagerCalled);
149+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
150150

151-
assertEquals(jni.searchPaths[0], soTestFilename);
151+
assertEquals(soTestFilename, jni.searchPaths[0]);
152152
assertTrue(jni.searchPaths[1].endsWith(soTestPath));
153-
assertEquals(jni.searchPaths.length, 2);
154-
assertEquals(jni.loadingUnitId, 123);
155-
assertEquals(jni.assetBundlePath, "custom_assets");
153+
assertEquals(2, jni.searchPaths.length);
154+
assertEquals(123, jni.loadingUnitId);
155+
assertEquals("custom_assets", jni.assetBundlePath);
156156
}
157157

158158
@Test
@@ -173,18 +173,18 @@ public void downloadCallsJNIFunctionsWithSharedLibraryNameFromManifest()
173173
TestPlayStoreDeferredComponentManager playStoreManager =
174174
new TestPlayStoreDeferredComponentManager(spyContext, jni);
175175
jni.setDeferredComponentManager(playStoreManager);
176-
assertEquals(jni.loadingUnitId, 0);
176+
assertEquals(0, jni.loadingUnitId);
177177

178178
playStoreManager.installDeferredComponent(123, "TestModuleName");
179-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
180-
assertEquals(jni.updateAssetManagerCalled, 1);
181-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
179+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
180+
assertEquals(1, jni.updateAssetManagerCalled);
181+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
182182

183-
assertEquals(jni.searchPaths[0], soTestFilename);
183+
assertEquals(soTestFilename, jni.searchPaths[0]);
184184
assertTrue(jni.searchPaths[1].endsWith(soTestPath));
185-
assertEquals(jni.searchPaths.length, 2);
186-
assertEquals(jni.loadingUnitId, 123);
187-
assertEquals(jni.assetBundlePath, "custom_assets");
185+
assertEquals(2, jni.searchPaths.length);
186+
assertEquals(123, jni.loadingUnitId);
187+
assertEquals("custom_assets", jni.assetBundlePath);
188188
}
189189

190190
@Test
@@ -205,17 +205,17 @@ public void manifestMappingHandlesBaseModuleEmptyString() throws NameNotFoundExc
205205
PlayStoreDeferredComponentManager playStoreManager =
206206
new PlayStoreDeferredComponentManager(spyContext, jni);
207207
jni.setDeferredComponentManager(playStoreManager);
208-
assertEquals(jni.loadingUnitId, 0);
208+
assertEquals(0, jni.loadingUnitId);
209209

210210
playStoreManager.installDeferredComponent(3, null);
211-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
212-
assertEquals(jni.updateAssetManagerCalled, 0); // no assets to load for base
213-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
211+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
212+
assertEquals(0, jni.updateAssetManagerCalled); // no assets to load for base
213+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
214214

215-
assertEquals(jni.searchPaths[0], soTestFilename);
215+
assertEquals(soTestFilename, jni.searchPaths[0]);
216216
assertTrue(jni.searchPaths[1].endsWith(soTestPath));
217-
assertEquals(jni.searchPaths.length, 2);
218-
assertEquals(jni.loadingUnitId, 3);
217+
assertEquals(2, jni.searchPaths.length);
218+
assertEquals(3, jni.loadingUnitId);
219219
}
220220

221221
@Test
@@ -229,17 +229,17 @@ public void searchPathsAddsApks() throws NameNotFoundException {
229229
new TestPlayStoreDeferredComponentManager(spyContext, jni);
230230
jni.setDeferredComponentManager(playStoreManager);
231231

232-
assertEquals(jni.loadingUnitId, 0);
232+
assertEquals(0, jni.loadingUnitId);
233233

234234
playStoreManager.installDeferredComponent(123, "TestModuleName");
235-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
236-
assertEquals(jni.updateAssetManagerCalled, 1);
237-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
235+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
236+
assertEquals(1, jni.updateAssetManagerCalled);
237+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
238238

239-
assertEquals(jni.searchPaths[0], "libapp.so-123.part.so");
239+
assertEquals("libapp.so-123.part.so", jni.searchPaths[0]);
240240
assertTrue(jni.searchPaths[1].endsWith(apkTestPath + "!lib/armeabi-v7a/libapp.so-123.part.so"));
241-
assertEquals(jni.searchPaths.length, 2);
242-
assertEquals(jni.loadingUnitId, 123);
241+
assertEquals(2, jni.searchPaths.length);
242+
assertEquals(123, jni.loadingUnitId);
243243
}
244244

245245
@Test
@@ -253,17 +253,17 @@ public void searchPathsSearchesSplitConfig() throws NameNotFoundException {
253253
new TestPlayStoreDeferredComponentManager(spyContext, jni);
254254
jni.setDeferredComponentManager(playStoreManager);
255255

256-
assertEquals(jni.loadingUnitId, 0);
256+
assertEquals(0, jni.loadingUnitId);
257257

258258
playStoreManager.installDeferredComponent(123, "TestModuleName");
259-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
260-
assertEquals(jni.updateAssetManagerCalled, 1);
261-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
259+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
260+
assertEquals(1, jni.updateAssetManagerCalled);
261+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
262262

263-
assertEquals(jni.searchPaths[0], "libapp.so-123.part.so");
263+
assertEquals("libapp.so-123.part.so", jni.searchPaths[0]);
264264
assertTrue(jni.searchPaths[1].endsWith(apkTestPath + "!lib/armeabi-v7a/libapp.so-123.part.so"));
265-
assertEquals(jni.searchPaths.length, 2);
266-
assertEquals(jni.loadingUnitId, 123);
265+
assertEquals(2, jni.searchPaths.length);
266+
assertEquals(123, jni.loadingUnitId);
267267
}
268268

269269
@Test
@@ -277,16 +277,16 @@ public void invalidSearchPathsAreIgnored() throws NameNotFoundException {
277277
new TestPlayStoreDeferredComponentManager(spyContext, jni);
278278
jni.setDeferredComponentManager(playStoreManager);
279279

280-
assertEquals(jni.loadingUnitId, 0);
280+
assertEquals(0, jni.loadingUnitId);
281281

282282
playStoreManager.installDeferredComponent(123, "TestModuleName");
283-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
284-
assertEquals(jni.updateAssetManagerCalled, 1);
285-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
283+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
284+
assertEquals(1, jni.updateAssetManagerCalled);
285+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
286286

287-
assertEquals(jni.searchPaths[0], "libapp.so-123.part.so");
288-
assertEquals(jni.searchPaths.length, 1);
289-
assertEquals(jni.loadingUnitId, 123);
287+
assertEquals("libapp.so-123.part.so", jni.searchPaths[0]);
288+
assertEquals(1, jni.searchPaths.length);
289+
assertEquals(123, jni.loadingUnitId);
290290
}
291291

292292
@Test
@@ -301,12 +301,12 @@ public void assetManagerUpdateInvoked() throws NameNotFoundException {
301301
new TestPlayStoreDeferredComponentManager(spyContext, jni);
302302
jni.setDeferredComponentManager(playStoreManager);
303303

304-
assertEquals(jni.loadingUnitId, 0);
304+
assertEquals(0, jni.loadingUnitId);
305305

306306
playStoreManager.installDeferredComponent(123, "TestModuleName");
307-
assertEquals(jni.loadDartDeferredLibraryCalled, 1);
308-
assertEquals(jni.updateAssetManagerCalled, 1);
309-
assertEquals(jni.deferredComponentInstallFailureCalled, 0);
307+
assertEquals(1, jni.loadDartDeferredLibraryCalled);
308+
assertEquals(1, jni.updateAssetManagerCalled);
309+
assertEquals(0, jni.deferredComponentInstallFailureCalled);
310310

311311
assertEquals(jni.assetManager, assetManager);
312312
}
@@ -318,7 +318,7 @@ public void stateGetterReturnsUnknowByDefault() throws NameNotFoundException {
318318
doReturn(null).when(spyContext).getAssets();
319319
TestPlayStoreDeferredComponentManager playStoreManager =
320320
new TestPlayStoreDeferredComponentManager(spyContext, jni);
321-
assertEquals(playStoreManager.getDeferredComponentInstallState(-1, "invalidName"), "unknown");
321+
assertEquals("unknown", playStoreManager.getDeferredComponentInstallState(-1, "invalidName"));
322322
}
323323

324324
@Test

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/renderer/FlutterRendererTest.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -780,8 +780,8 @@ public void ImageReaderSurfaceProducerClampsWidthAndHeightTo1() {
780780
TextureRegistry.SurfaceProducer producer = flutterRenderer.createSurfaceProducer();
781781

782782
// Default values.
783-
assertEquals(producer.getWidth(), 1);
784-
assertEquals(producer.getHeight(), 1);
783+
assertEquals(1, producer.getWidth());
784+
assertEquals(1, producer.getHeight());
785785

786786
// Try setting width and height to 0.
787787
producer.setSize(0, 0);
@@ -790,8 +790,8 @@ public void ImageReaderSurfaceProducerClampsWidthAndHeightTo1() {
790790
assertNotNull(producer.getSurface());
791791

792792
// Expect clamp to 1.
793-
assertEquals(producer.getWidth(), 1);
794-
assertEquals(producer.getHeight(), 1);
793+
assertEquals(1, producer.getWidth());
794+
assertEquals(1, producer.getHeight());
795795
}
796796

797797
@Test
@@ -806,7 +806,7 @@ public void SurfaceTextureSurfaceProducerCreatesAConnectedTexture() {
806806
flutterRenderer.startRenderingToSurface(fakeSurface, false);
807807

808808
// Verify behavior under test.
809-
assertEquals(producer.id(), 0);
809+
assertEquals(0, producer.id());
810810
verify(fakeFlutterJNI, times(1)).registerTexture(eq(producer.id()), any());
811811
} finally {
812812
FlutterRenderer.debugForceSurfaceProducerGlTextures = false;

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/renderer/SurfaceTextureSurfaceProducerTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,15 @@ public void createsSurfaceTextureOfGivenSizeAndResizesWhenRequested() {
5959
canvas.drawARGB(255, 255, 0, 0);
6060
surface.unlockCanvasAndPost(canvas);
6161
shadowOf(Looper.getMainLooper()).idle();
62-
assertEquals(frames.get(), 1);
62+
assertEquals(1, frames.get());
6363

6464
// Resize and redraw.
6565
producer.setSize(400, 800);
6666
canvas = surface.lockHardwareCanvas();
6767
canvas.drawARGB(255, 255, 0, 0);
6868
surface.unlockCanvasAndPost(canvas);
6969
shadowOf(Looper.getMainLooper()).idle();
70-
assertEquals(frames.get(), 2);
70+
assertEquals(2, frames.get());
7171

7272
// Done.
7373
fakeJNI.detachFromNativeAndReleaseResources();

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/renderer/SurfaceTextureWrapperTest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
package io.flutter.embedding.engine.renderer;
66

7-
import static junit.framework.TestCase.*;
87
import static org.mockito.Mockito.*;
98

109
import android.graphics.SurfaceTexture;

‎engine/src/flutter/shell/platform/android/test/io/flutter/embedding/engine/systemchannels/PlatformChannelTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void platformChannel_shareInvokeMessage() {
6666
MethodChannel.Result mockResult = mock(MethodChannel.Result.class);
6767
fakePlatformChannel.parsingMethodCallHandler.onMethodCall(methodCall, mockResult);
6868

69-
assertEquals(valueCapture.getValue(), expectedContent);
69+
assertEquals(expectedContent, valueCapture.getValue());
7070
verify(mockResult).success(null);
7171
}
7272
}

0 commit comments

Comments
 (0)