Skip to content

Commit 3a090b4

Browse files
authored
fml: Delete weak_nsobject.h,mm (#56289)
These classes are no longer necessary now that the entire codebase has been migrated to ARC. Issue: #137801 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 0a0d5c9 commit 3a090b4

9 files changed

Lines changed: 2 additions & 583 deletions

File tree

‎ci/licenses_golden/excluded_files‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,6 @@
109109
../../../flutter/fml/platform/darwin/scoped_nsobject_arc_unittests.mm
110110
../../../flutter/fml/platform/darwin/scoped_nsobject_unittests.mm
111111
../../../flutter/fml/platform/darwin/string_range_sanitization_unittests.mm
112-
../../../flutter/fml/platform/darwin/weak_nsobject_arc_unittests.mm
113-
../../../flutter/fml/platform/darwin/weak_nsobject_unittests.mm
114112
../../../flutter/fml/platform/fuchsia/log_interest_listener_unittests.cc
115113
../../../flutter/fml/platform/win/file_win_unittests.cc
116114
../../../flutter/fml/platform/win/wstring_conversion_unittests.cc

‎ci/licenses_golden/licenses_flutter‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42739,8 +42739,6 @@ ORIGIN: ../../../flutter/fml/platform/darwin/scoped_policy.h + ../../../flutter/
4273942739
ORIGIN: ../../../flutter/fml/platform/darwin/scoped_typeref.h + ../../../flutter/LICENSE
4274042740
ORIGIN: ../../../flutter/fml/platform/darwin/string_range_sanitization.h + ../../../flutter/LICENSE
4274142741
ORIGIN: ../../../flutter/fml/platform/darwin/string_range_sanitization.mm + ../../../flutter/LICENSE
42742-
ORIGIN: ../../../flutter/fml/platform/darwin/weak_nsobject.h + ../../../flutter/LICENSE
42743-
ORIGIN: ../../../flutter/fml/platform/darwin/weak_nsobject.mm + ../../../flutter/LICENSE
4274442742
ORIGIN: ../../../flutter/fml/platform/fuchsia/log_interest_listener.cc + ../../../flutter/LICENSE
4274542743
ORIGIN: ../../../flutter/fml/platform/fuchsia/log_interest_listener.h + ../../../flutter/LICENSE
4274642744
ORIGIN: ../../../flutter/fml/platform/fuchsia/log_state.cc + ../../../flutter/LICENSE
@@ -45601,8 +45599,6 @@ FILE: ../../../flutter/fml/platform/darwin/scoped_policy.h
4560145599
FILE: ../../../flutter/fml/platform/darwin/scoped_typeref.h
4560245600
FILE: ../../../flutter/fml/platform/darwin/string_range_sanitization.h
4560345601
FILE: ../../../flutter/fml/platform/darwin/string_range_sanitization.mm
45604-
FILE: ../../../flutter/fml/platform/darwin/weak_nsobject.h
45605-
FILE: ../../../flutter/fml/platform/darwin/weak_nsobject.mm
4560645602
FILE: ../../../flutter/fml/platform/fuchsia/log_interest_listener.cc
4560745603
FILE: ../../../flutter/fml/platform/fuchsia/log_interest_listener.h
4560845604
FILE: ../../../flutter/fml/platform/fuchsia/log_state.cc

‎fml/BUILD.gn‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,6 @@ source_set("fml") {
162162
"platform/darwin/scoped_typeref.h",
163163
"platform/darwin/string_range_sanitization.h",
164164
"platform/darwin/string_range_sanitization.mm",
165-
"platform/darwin/weak_nsobject.h",
166-
"platform/darwin/weak_nsobject.mm",
167165
]
168166

169167
frameworks = [ "Foundation.framework" ]
@@ -377,10 +375,7 @@ if (enable_unittests) {
377375
}
378376

379377
if (is_mac || is_ios) {
380-
sources += [
381-
"platform/darwin/scoped_nsobject_unittests.mm",
382-
"platform/darwin/weak_nsobject_unittests.mm",
383-
]
378+
sources += [ "platform/darwin/scoped_nsobject_unittests.mm" ]
384379
}
385380

386381
if (is_fuchsia) {
@@ -418,10 +413,7 @@ if (enable_unittests) {
418413
testonly = true
419414
if (is_mac || is_ios) {
420415
cflags_objcc = flutter_cflags_objc_arc
421-
sources = [
422-
"platform/darwin/scoped_nsobject_arc_unittests.mm",
423-
"platform/darwin/weak_nsobject_arc_unittests.mm",
424-
]
416+
sources = [ "platform/darwin/scoped_nsobject_arc_unittests.mm" ]
425417
}
426418

427419
deps = [

‎fml/platform/darwin/weak_nsobject.h‎

Lines changed: 0 additions & 282 deletions
This file was deleted.

0 commit comments

Comments
 (0)