Skip to content

Commit 38ec981

Browse files
[CP-beta]Move iOS compile benchmarks to Mac_benchmark and pin Mac_benchmark to M1 (#193572)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? https://github.com/flutter/flutter/issues/< Replace with issue link here > ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick. Release branch is currently failing due to Infra configurations (all Mac_benchmark tests are unable to find bot): https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.49-candidate.0 This should fix it. ### Changelog Description: Explain this cherry pick: * In one line that is accessible to most Flutter developers. * That describes the state prior to the fix. * That includes which platforms are impacted. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. < Replace with changelog description here > [flutter/<ISSUE_NUMBER>] When <SCENARIO> [on <PLAFORMS(S)>], <DESCRIPTION> N/A - This is an Infra configuration only change to unblock the tree ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A
1 parent fafcafc commit 38ec981

1 file changed

Lines changed: 19 additions & 14 deletions

File tree

‎.ci.yaml‎

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,15 @@ platform_properties:
211211
{"dependency": "apple_signing", "version": "version:to_2027"}
212212
]
213213
device_type: none
214-
mac_model: "Macmini8,1"
214+
# Benchmarks are pinned to a single Mac model so that timing metrics are
215+
# comparable across runs. Macmini9,1 is the Apple Silicon (M1) Mac mini;
216+
# the Intel Macmini8,1 bots are being turned down
217+
# (https://flutter.dev/go/macos-intel-deprecation).
218+
mac_model: "Macmini9,1"
219+
cpu: arm64
215220
os: Mac-15.7
216221
tags: >
217-
["devicelab", "hostonly", "mac"]
222+
["devicelab", "hostonly", "mac", "arm64"]
218223
$flutter/osx_sdk : >-
219224
{
220225
"sdk_version": "17c52"
@@ -5350,13 +5355,12 @@ targets:
53505355
["devicelab", "ios", "mac"]
53515356
task_name: backdrop_filter_perf_ios__timeline_summary
53525357

5353-
- name: Mac_arm64_ios basic_material_app_ios__compile
5358+
- name: Mac_benchmark basic_material_app_ios__compile
53545359
recipe: devicelab/devicelab_drone
53555360
presubmit: false
5361+
bringup: true
53565362
timeout: 60
53575363
properties:
5358-
tags: >
5359-
["devicelab", "ios", "mac"]
53605364
task_name: basic_material_app_ios__compile
53615365

53625366
- name: Mac channels_integration_test_ios
@@ -5461,13 +5465,16 @@ targets:
54615465
["devicelab", "hostonly", "mac"]
54625466
task_name: flavors_test_ios
54635467

5464-
- name: Mac_arm64_ios flutter_gallery_ios__compile
5468+
- name: Mac_benchmark flutter_gallery_ios__compile
54655469
recipe: devicelab/devicelab_drone
54665470
presubmit: false
5471+
bringup: true
54675472
timeout: 60
54685473
properties:
5469-
tags: >
5470-
["devicelab", "ios", "mac", "arm64"]
5474+
dependencies: >-
5475+
[
5476+
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
5477+
]
54715478
task_name: flutter_gallery_ios__compile
54725479

54735480
- name: Mac_ios flutter_gallery_ios__start_up
@@ -5488,22 +5495,20 @@ targets:
54885495
["devicelab", "ios", "mac"]
54895496
task_name: flutter_view_ios__start_up
54905497

5491-
- name: Mac_arm64_ios hello_world_ios__compile
5498+
- name: Mac_benchmark hello_world_ios__compile
54925499
recipe: devicelab/devicelab_drone
54935500
presubmit: false
5501+
bringup: true
54945502
timeout: 60
54955503
properties:
5496-
tags: >
5497-
["devicelab", "ios", "mac", "arm64"]
54985504
task_name: hello_world_ios__compile
54995505

5500-
- name: Mac_arm64_ios imitation_game_flutter
5506+
- name: Mac_benchmark imitation_game_flutter
55015507
recipe: devicelab/devicelab_drone
55025508
presubmit: false
5509+
bringup: true
55035510
timeout: 60
55045511
properties:
5505-
tags: >
5506-
["devicelab", "ios", "mac", "arm64"]
55075512
task_name: imitation_game_flutter__compile
55085513

55095514
- name: Mac_arm64_ios imitation_game_swiftui

0 commit comments

Comments
 (0)