Skip to content

Commit 3656144

Browse files
gnpricepull[bot]
authored andcommitted
Support failures-only and silent reporters in flutter test (#148739)
Fixes #148738. Also add some tests for this part of the `flutter test` CLI.
1 parent 3f381f3 commit 3656144

2 files changed

Lines changed: 61 additions & 2 deletions

File tree

‎packages/flutter_tools/lib/src/commands/test.dart‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,14 @@ class TestCommand extends FlutterCommand with DeviceBasedDevelopmentArtifacts {
216216
..addOption('reporter',
217217
abbr: 'r',
218218
help: 'Set how to print test results. If unset, value will default to either compact or expanded.',
219-
allowed: <String>['compact', 'expanded', 'github', 'json'],
219+
allowed: <String>['compact', 'expanded', 'failures-only', 'github', 'json', 'silent'],
220220
allowedHelp: <String, String>{
221-
'compact': 'A single line that updates dynamically (The default reporter).',
221+
'compact': 'A single line, updated continuously (the default).',
222222
'expanded': 'A separate line for each update. May be preferred when logging to a file or in continuous integration.',
223+
'failures-only': 'A separate line for failing tests, with no output for passing tests.',
223224
'github': 'A custom reporter for GitHub Actions (the default reporter when running on GitHub Actions).',
224225
'json': 'A machine-readable format. See: https://dart.dev/go/test-docs/json_reporter.md',
226+
'silent': 'A reporter with no output. May be useful when only the exit code is meaningful.'
225227
},
226228
)
227229
..addOption('file-reporter',

‎packages/flutter_tools/test/commands.shard/hermetic/test_test.dart‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,63 @@ dev_dependencies:
283283
});
284284
});
285285

286+
group('--reporter/-r', () {
287+
String? passedReporter(List<String> args) {
288+
final int i = args.indexOf('-r');
289+
if (i < 0) {
290+
expect(args, isNot(contains('--reporter')));
291+
expect(args, isNot(contains(matches(RegExp(r'^(-r|--reporter=)')))));
292+
return null;
293+
} else {
294+
return args[i+1];
295+
}
296+
}
297+
298+
Future<void> expectPassesReporter(String value) async {
299+
final FakePackageTest fakePackageTest = FakePackageTest();
300+
final TestCommand testCommand = TestCommand(testWrapper: fakePackageTest);
301+
final CommandRunner<void> commandRunner = createTestCommandRunner(testCommand);
302+
303+
await commandRunner.run(<String>['test', '--no-pub', '-r', value]);
304+
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
305+
306+
await commandRunner.run(<String>['test', '--no-pub', '-r$value']);
307+
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
308+
309+
await commandRunner.run(<String>['test', '--no-pub', '--reporter', value]);
310+
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
311+
312+
await commandRunner.run(<String>['test', '--no-pub', '--reporter=$value']);
313+
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
314+
}
315+
316+
testUsingContext('accepts valid values and passes them through', () async {
317+
await expectPassesReporter('compact');
318+
await expectPassesReporter('expanded');
319+
await expectPassesReporter('failures-only');
320+
await expectPassesReporter('github');
321+
await expectPassesReporter('json');
322+
await expectPassesReporter('silent');
323+
}, overrides: <Type, Generator>{
324+
FileSystem: () => fs,
325+
ProcessManager: () => FakeProcessManager.any(),
326+
Cache: () => Cache.test(processManager: FakeProcessManager.any()),
327+
});
328+
329+
testUsingContext('by default, passes no reporter', () async {
330+
final FakePackageTest fakePackageTest = FakePackageTest();
331+
final TestCommand testCommand = TestCommand(testWrapper: fakePackageTest);
332+
final CommandRunner<void> commandRunner = createTestCommandRunner(testCommand);
333+
334+
await commandRunner.run(<String>['test', '--no-pub']);
335+
expect(passedReporter(fakePackageTest.lastArgs!), isNull);
336+
}, overrides: <Type, Generator>{
337+
FileSystem: () => fs,
338+
ProcessManager: () => FakeProcessManager.any(),
339+
Cache: () => Cache.test(processManager: FakeProcessManager.any()),
340+
});
341+
});
342+
286343
testUsingContext('Supports coverage and machine', () async {
287344
final FakePackageTest fakePackageTest = FakePackageTest();
288345

0 commit comments

Comments
 (0)