Repository navigation
Commit 361201b
authored
[stable] Skip platform tooling regeneration for non-Flutter pub workspace packages (#191270)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
### Issue Link:
#189550
### Impact Description:
In Dart workspaces containing both Flutter and non-Flutter packages, running `flutter pub get` post-processing unconditionally regenerated platform-specific tooling for all workspace packages. This caused non-Flutter packages to have their `analysis_options.yaml` modified (adding platform exclusions) and stray `ios/` or `android/` directories populated with generated Flutter project files (`GeneratedPluginRegistrant.*`, `Generated.xcconfig`, etc.).
### Changelog Description:
[flutter/189550] When running `flutter pub get` in a Dart workspace, platform tooling regeneration and analysis options migration are skipped for packages that do not depend on Flutter.
### Workaround:
Manually revert generated files and `analysis_options.yaml` changes in non-Flutter packages after running `flutter pub get`.
### Risk:
### Test Coverage:
### Validation Steps:
1. Create a Dart workspace containing a plain Dart package and a Flutter app package.
2. Run `flutter pub get` from the workspace root.
3. Verify that the plain Dart package's `analysis_options.yaml` remains unmodified and no platform files are created in its directory.
4. Verify that the Flutter app package is still properly processed.1 parent e5b61cd commit 361201b
2 files changed
Lines changed: 83 additions & 6 deletions
File tree
- packages/flutter_tools
- lib/src/commands
- test/commands.shard/permeable
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
397 | 399 | | |
398 | 400 | | |
399 | 401 | | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
406 | 416 | | |
407 | 417 | | |
408 | 418 | | |
| |||
423 | 433 | | |
424 | 434 | | |
425 | 435 | | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
426 | 457 | | |
427 | 458 | | |
428 | 459 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
458 | 458 | | |
459 | 459 | | |
460 | 460 | | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
461 | 507 | | |
462 | 508 | | |
463 | 509 | | |
| |||
0 commit comments