Skip to content

Commit 33e5155

Browse files
Fix static analysis issues in web_ui
1 parent 00250e1 commit 33e5155

7 files changed

Lines changed: 8 additions & 5 deletions

File tree

‎engine/src/flutter/lib/web_ui/lib/src/engine.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ export 'engine/backend/codec.dart';
2222
export 'engine/backend/image.dart';
2323
export 'engine/backend/path.dart';
2424
export 'engine/browser_detection.dart';
25+
export 'engine/canvaskit/animated_image.dart';
2526
export 'engine/canvaskit/canvas.dart';
2627
export 'engine/canvaskit/canvaskit_api.dart';
2728
export 'engine/canvaskit/color_filter.dart';
2829
export 'engine/canvaskit/fonts.dart';
2930
export 'engine/canvaskit/image.dart';
3031
export 'engine/canvaskit/image_filter.dart';
31-
export 'engine/canvaskit/animated_image.dart';
3232
export 'engine/canvaskit/mask_filter.dart';
3333
export 'engine/canvaskit/native_memory.dart';
3434
export 'engine/canvaskit/painting.dart';

‎engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/image.dart‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@ class CkImageDelegate implements BackendImage {
1212
final SkImage skImage;
1313

1414
/// Returns the width of the image in pixels.
15+
@override
1516
int get width => skImage.width().toInt();
1617

1718
/// Returns the height of the image in pixels.
19+
@override
1820
int get height => skImage.height().toInt();
1921

2022
/// Releases the native memory allocated for the Skia image.

‎engine/src/flutter/lib/web_ui/lib/src/engine/dom.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ extension type ImageBitmapOptions._primary(JSObject _) implements JSObject {
334334
int? resizeHeight,
335335
String? resizeQuality,
336336
}) {
337-
final JSObject obj = JSObject();
337+
final obj = JSObject();
338338
if (imageOrientation != null) {
339339
obj['imageOrientation'] = imageOrientation.toJS;
340340
}

‎engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl/image.dart‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ class SkwasmImage implements BackendImage {
2525
imageDispose(handle);
2626
}
2727

28+
@override
2829
int get width => imageGetWidth(handle);
2930

31+
@override
3032
int get height => imageGetHeight(handle);
3133

3234
@override

‎engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_stub/renderer.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// found in the LICENSE file.
44

55
import 'dart:async';
6-
import 'dart:js_interop';
76
import 'dart:math' as math;
87
import 'dart:typed_data';
98

‎engine/src/flutter/lib/web_ui/test/skwasm/native_memory_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ void testMain() {
2424
1,
2525
ui.PixelFormat.rgba8888,
2626
);
27-
final EngineImage image = EngineImage(backendImage, 1, 1);
27+
final image = EngineImage(backendImage, 1, 1);
2828

2929
final EngineImage clone = image.clone();
3030
expect(

‎engine/src/flutter/lib/web_ui/test/ui/image_golden_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ Future<void> testMain() async {
438438

439439
expect(bitmap.width, 150);
440440
expect(bitmap.height, 150);
441-
final ui.Image uiImage = await renderer.createImageFromImageBitmap(bitmap);
441+
final ui.Image uiImage = renderer.createImageFromImageBitmap(bitmap);
442442

443443
if (isSkwasm && isMultiThreaded) {
444444
// Multi-threaded skwasm transfers the bitmap to the web worker, so it should be

0 commit comments

Comments
 (0)