Skip to content

Commit 31e464f

Browse files
committed
Assign testSuite before invoking synchronous setUp() in test setup
1 parent 6c1c11e commit 31e464f

18 files changed

Lines changed: 38 additions & 19 deletions

‎dev/flutter_analyzer_plugin/README.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,8 @@ void main() {
495495
late MyCustomRuleTest testSuite;
496496
497497
setUp(() {
498-
testSuite = MyCustomRuleTest()..setUp();
498+
testSuite = MyCustomRuleTest();
499+
testSuite.setUp();
499500
});
500501
501502
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/avoid_future_catch_error_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ void main() {
4343
late AvoidFutureCatchErrorTest testSuite;
4444

4545
setUp(() {
46-
testSuite = AvoidFutureCatchErrorTest()..setUp();
46+
testSuite = AvoidFutureCatchErrorTest();
47+
testSuite.setUp();
4748
});
4849

4950
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/deprecation_syntax_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ void main() {
3939
late DeprecationSyntaxTest testSuite;
4040

4141
setUp(() {
42-
testSuite = DeprecationSyntaxTest()..setUp();
42+
testSuite = DeprecationSyntaxTest();
43+
testSuite.setUp();
4344
});
4445

4546
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/golden_test_tags_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ void main() {
4040
late GoldenTestTagsTest testSuite;
4141

4242
setUp(() {
43-
testSuite = GoldenTestTagsTest()..setUp();
43+
testSuite = GoldenTestTagsTest();
44+
testSuite.setUp();
4445
});
4546

4647
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/integration_test_timeouts_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ void main() {
3939
late IntegrationTestTimeoutsTest testSuite;
4040

4141
setUp(() {
42-
testSuite = IntegrationTestTimeoutsTest()..setUp();
42+
testSuite = IntegrationTestTimeoutsTest();
43+
testSuite.setUp();
4344
});
4445

4546
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/issue_link_syntax_test.dart‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ void main() {
3737
late IssueLinkSyntaxTest testSuite;
3838

3939
setUp(() {
40-
testSuite = IssueLinkSyntaxTest()..setUp();
40+
testSuite = IssueLinkSyntaxTest();
41+
testSuite.setUp();
4142
});
4243

4344
tearDown(() => testSuite.tearDown());
@@ -126,7 +127,8 @@ void main() {
126127
late IssueLinkSyntaxTestFileTest testSuite;
127128

128129
setUp(() {
129-
testSuite = IssueLinkSyntaxTestFileTest()..setUp();
130+
testSuite = IssueLinkSyntaxTestFileTest();
131+
testSuite.setUp();
130132
});
131133

132134
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/no_bad_imports_in_flutter_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ void main() {
4242
late NoBadImportsInFlutterTest testSuite;
4343

4444
setUp(() {
45-
testSuite = NoBadImportsInFlutterTest()..setUp();
45+
testSuite = NoBadImportsInFlutterTest();
46+
testSuite.setUp();
4647
});
4748

4849
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/no_double_clamp_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ void main() {
5555
late NoDoubleClampTest testSuite;
5656

5757
setUp(() {
58-
testSuite = NoDoubleClampTest()..setUp();
58+
testSuite = NoDoubleClampTest();
59+
testSuite.setUp();
5960
});
6061

6162
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/no_runtimetype_in_tostring_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ void main() {
6161
late NoRuntimeTypeInToStringTest testSuite;
6262

6363
setUp(() {
64-
testSuite = NoRuntimeTypeInToStringTest()..setUp();
64+
testSuite = NoRuntimeTypeInToStringTest();
65+
testSuite.setUp();
6566
});
6667

6768
tearDown(() => testSuite.tearDown());

‎dev/flutter_analyzer_plugin/test/no_stopwatches_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ void main() {
101101
late NoStopwatchesTest testSuite;
102102

103103
setUp(() {
104-
testSuite = NoStopwatchesTest()..setUp();
104+
testSuite = NoStopwatchesTest();
105+
testSuite.setUp();
105106
});
106107

107108
tearDown(() => testSuite.tearDown());

0 commit comments

Comments
 (0)