Repository navigation
Commit 24489a0
committed
[Impeller] Use the default geometry callback in circle and UberSDF contents
CircleContents and UberSDFContents were the only contents passing a custom
create_geom_callback, and it only returned a precomputed GetPositionBuffer
result. The default callback performs the same call, and neither
CircleGeometry nor UberSDFGeometry overrides GetResultMode (both are
kNormal). force_stencil was false as well, so the stencil-then-cover path
never engaged.
This also removes the now-unused geometry_result precompute.
test-exempt: refactor with no behavior change; existing golden tests cover
both pipelines.1 parent e8834b8 commit 24489a0
2 files changed
Lines changed: 2 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
56 | 54 | | |
57 | 55 | | |
58 | 56 | | |
| |||
62 | 60 | | |
63 | 61 | | |
64 | 62 | | |
65 | | - | |
66 | | - | |
67 | 63 | | |
68 | 64 | | |
69 | 65 | | |
70 | 66 | | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 67 | + | |
79 | 68 | | |
80 | 69 | | |
81 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | 156 | | |
160 | 157 | | |
161 | 158 | | |
| |||
165 | 162 | | |
166 | 163 | | |
167 | 164 | | |
168 | | - | |
169 | | - | |
170 | 165 | | |
171 | 166 | | |
172 | 167 | | |
173 | 168 | | |
174 | 169 | | |
175 | 170 | | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
| 171 | + | |
184 | 172 | | |
185 | 173 | | |
186 | 174 | | |
| |||
0 commit comments