Skip to content

Commit 1366874

Browse files
Address review: drop android.compatibility.enableLegacyApi from the qa section
AGP 9.1 and 9.3 deprecate the option. Its consumers back the variant API that android.newDsl=true already removes.
1 parent 798ac29 commit 1366874

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎dev/devicelab/bin/tasks/module_host_with_custom_build_test.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,14 +275,14 @@ Future<void> main() async {
275275

276276
section('Run app:assembleDemoQa with android.newDsl=true');
277277

278-
// With android.newDsl=true, AGP has no `libraryVariants` or `applicationVariants`.
278+
// The fixture's gradle.properties sets android.newDsl=false. With
279+
// android.newDsl=true, AGP has no `libraryVariants` or `applicationVariants`.
279280
final String demoQaOutput = await inDirectory(hostAppDir, () async {
280281
return eval(
281282
gradlewExecutable,
282283
<String>[
283284
'app:assembleDemoQa',
284285
'-Pandroid.newDsl=true',
285-
'-Pandroid.compatibility.enableLegacyApi=false',
286286
'-Pflutter.hostAppProjectName=app',
287287
],
288288
environment: <String, String>{'JAVA_HOME': javaHome},

0 commit comments

Comments
 (0)