Skip to content

Commit 0f21c6d

Browse files
committed
Dispose paragraph and picture in try/finally after toImage completes
1 parent 792f8dd commit 0f21c6d

1 file changed

Lines changed: 13 additions & 8 deletions

File tree

‎engine/src/flutter/lib/web_ui/test/ui/text_test.dart‎

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,19 @@ void testMain() {
6666
final recorder = ui.PictureRecorder();
6767
final canvas = ui.Canvas(recorder, bounds);
6868
final ui.Paragraph paragraph = makeSimpleText(text);
69-
70-
canvas.drawParagraph(paragraph, ui.Offset.zero);
71-
paragraph.dispose();
72-
final ui.Picture picture = recorder.endRecording();
73-
final ui.Image image = await picture.toImage(100, 100);
74-
picture.dispose();
75-
addTearDown(image.dispose);
76-
return image;
69+
try {
70+
canvas.drawParagraph(paragraph, ui.Offset.zero);
71+
final ui.Picture picture = recorder.endRecording();
72+
try {
73+
final ui.Image image = await picture.toImage(100, 100);
74+
addTearDown(image.dispose);
75+
return image;
76+
} finally {
77+
picture.dispose();
78+
}
79+
} finally {
80+
paragraph.dispose();
81+
}
7782
}
7883

7984
// The backspace character, \b, and unassigned codepoint \u0378 do not

0 commit comments

Comments
 (0)