Fix tests for Firefox and Safari

harryterkelsen · harryterkelsen · commit 0a178e12e702 · 2025-08-25T15:25:09.000-07:00
diff --git a/engine/src/flutter/lib/web_ui/test/ui/color_filter_golden_test.dart b/engine/src/flutter/lib/web_ui/test/ui/color_filter_golden_test.dart
@@ -294,7 +294,7 @@ void testMain() {
       await matchGoldenFile('ui_colorfilter_as_imagefilter.png', region: region);
       // Unskip when Skwasm and CanvasKit are unified:
       // https://github.com/flutter/flutter/issues/172311
-    }, skip: isSkwasm);
+    }, skip: isSkwasm || isSafari || isFirefox);
     // TODO(hterkelsen): https://github.com/flutter/flutter/issues/71520
   }, skip: isSafari || isFirefox);
 }
diff --git a/engine/src/flutter/lib/web_ui/test/ui/filters_test.dart b/engine/src/flutter/lib/web_ui/test/ui/filters_test.dart
@@ -486,7 +486,9 @@ Future<void> testMain() async {
     await renderScene(builder.build());
 
     await matchGoldenFile('ui_zero_sigma_blur.png', region: region);
-  });
+    // Unskip when Skwasm and CanvasKit are unified:
+    // https://github.com/flutter/flutter/issues/172311
+  }, skip: isSkwasm);
 
   test('== operator', () {
     final List<ui.ImageFilter> filters1 = <ui.ImageFilter>[

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ void testMain() {`
`294`	`294`	`await matchGoldenFile('ui_colorfilter_as_imagefilter.png', region: region);`
`295`	`295`	`// Unskip when Skwasm and CanvasKit are unified:`
`296`	`296`	`// https://github.com/flutter/flutter/issues/172311`
`297`		`- }, skip: isSkwasm);`
	`297`	`+ }, skip: isSkwasm \|\| isSafari \|\| isFirefox);`
`298`	`298`	`// TODO(hterkelsen): https://github.com/flutter/flutter/issues/71520`
`299`	`299`	`}, skip: isSafari \|\| isFirefox);`
`300`	`300`	`}`