[Windows] Alternative Windows shell platform implementation #9835

clarkezone · 2019-07-16T04:09:40Z

Start work on flutter/flutter#30726 by adding an alternative win32 shell platform implementation for Windows that is not based on GLFW and that uses LIBANGLE for rendering and native win32 windowing and input. This change does not replace the GLFW implementation but rather runs side by side with it producing a secondary flutter_windows_win32.dll artifact. The following items must be added to attain parity with the GLFW implementation:

Custom task scheduling
Support for keyboard modifier keys
Async texture uploads
Correct high DPI handling on Windows versions < 1703

and will be added in subsequent changes. The change is dependent on flutter/buildroot#276 which will need to land ahead of this one. @stuartmorgan for FYI

stuartmorgan-g · 2019-07-17T16:58:20Z

The change is dependent on an update to buildroot to add support for LIBANGLE which will need to land ahead of this one.

Posted as flutter/buildroot#276

stuartmorgan-g

First pass comments. I'll need to do a lot more review, since I'm not familiar with Windows APIs, there are a number of important classes with no comments, and there's a whole lot of code.

In retrospect I think it would have been much better to cut this into incremental PRs with a very small initial scope (e.g., just drawing, with no event handling, plugin support, etc.) and then incrementally expanding. That would have been much easier to review, and would likely have avoided the unfortunate replication of a lot of structure from the GLFW embedding that we don't actually want. However, given that doing that now would probably set things back substantially I'm fine to go forward with the PR in this basic structure, and then iterating from there.

DEPS

stuartmorgan-g · 2019-07-17T17:05:20Z

shell/platform/glfw/keyboard_hook_handler.h


  // A function for hooking into unicode code point input.
-  virtual void CharHook(GLFWwindow* window, unsigned int code_point) = 0;
+  virtual void CharHook(GLFWwindow* window,


This should be reverted, as it's unrelated to the PR.

I've tried various git approaches none of which have worked. How do you recommend I revert this?

shell/platform/glfw/client_wrapper/BUILD.gn

shell/platform/windows/BUILD.gn

shell/platform/windows/win32_window.cc

shell/platform/windows/win32_window.h

shell/platform/windows/window_state.h

…form messages

stuartmorgan-g

Updated with some follow up on my earlier comments. After giving this more thought several of the structural changes I had requested initially are really better done later as you suggested, given that this is a duplicate-and-evolve-from-glfw rather than a fresh start.

shell/platform/windows/BUILD.gn

shell/platform/windows/angle_surface_manager.cc

shell/platform/windows/client_wrapper/include/flutter/flutter_window.h

shell/platform/windows/flutter_window.cc

shell/platform/windows/public/flutter_windows.h

shell/platform/windows/text_input_plugin.cc

shell/platform/windows/window_state.h

Adds the ability to publish multiple folders of client wrappers. Uses that functionality to publish the original version, a _glfw version (which is the the same as the original, and will replace it after recipe updates) and a _windows version. Also restructures the dependency handling for the win32 and glfw versions slightly, including new groups and conditionizing on build_glfw_shell now (even though it's on by default).

stuartmorgan-g · 2019-07-18T22:59:49Z

I pushed some GN changes that handle publishing several copies of the wrapper (one for win32, one for GLFW, each with copies of the core files).

…fixing embedder.h symbols (flutter#9851)

clarkezone

Unclear why i started a review

shell/platform/windows/flutter_window.cc

shell/platform/windows/flutter_window.h

shell/platform/windows/flutter_window.cc

shell/platform/windows/win32_window.cc

clarkezone · 2019-07-27T21:31:06Z

shell/platform/glfw/keyboard_hook_handler.h


  // A function for hooking into unicode code point input.
-  virtual void CharHook(GLFWwindow* window, unsigned int code_point) = 0;
+  virtual void CharHook(GLFWwindow* window,


I've tried various git approaches none of which have worked. How do you recommend I revert this?

shell/platform/glfw/client_wrapper/BUILD.gn

shell/platform/windows/BUILD.gn

shell/platform/windows/flutter_window.cc

clarkezone · 2019-08-07T04:29:09Z

Is there an autoformatting tool that works on windows? I was doing it manually

stuartmorgan-g · 2019-08-07T04:33:08Z

IIRC I have clang-format working on Windows. That patch was created on my macOS machine though since that's what I happened to be on at the moment.

stuartmorgan-g · 2019-08-07T04:41:00Z

FYI I'm going to have to revert the buildroot roll in a few minutes, since my patch broke other unit tests, and other buildroot changes landed between that and the fix that I can't easily roll past. I'll work on getting that resolved tomorrow to unblock again.

stuartmorgan-g · 2019-08-07T04:57:20Z

I'll work on the new license script issues (the current format_and_dart_test failures) tomorrow.

stuartmorgan-g · 2019-08-14T18:04:39Z

Filed https://bugs.chromium.org/p/angleproject/issues/detail?id=3811 about the fact that we're shipping ~40 copies of the ANGLE license; if that's resolved the effects on distribution size from this PR will be reduced substantially.

stuartmorgan-g · 2019-08-15T00:19:52Z

The primary builder for Windows just went green for this commit—it looks like it's finally landed, to stay! \o/

I've starting filing some of the follow-up bugs, and will continue to do so tomorrow.

…lutter/engine#9835)

[email protected]:flutter/engine.git/compare/c5e30553cd1a...5e155c6 git log c5e3055..5e155c6 --no-merges --oneline 2019-08-14 [email protected] some drive-by docs while I was reading the embedding classes (flutter/engine#9341) 2019-08-14 [email protected] Initialize the engine in the running state to match the animator's default state (flutter/engine#11011) 2019-08-14 [email protected] Trace RasterCacheResult::Draw (flutter/engine#11004) 2019-08-14 [email protected] Rename macOS FLE* classes to Flutter* (flutter/engine#11010) 2019-08-14 [email protected] [Windows] Alternative Windows shell platform implementation (flutter/engine#9835) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.

clarkezone · 2019-08-15T01:52:33Z

@stuartmorgan sounds good re followup bugs.. is there a view / query / tag that aggregates them all?

stuartmorgan-g · 2019-08-15T03:06:24Z

This query will get all the Windows engine bugs. For what's needed to switch over I'm just using a tracking bug since it's a pretty short list, so didn't seem like it needed a whole project.

tvolkert · 2019-08-15T17:48:44Z

This regressed our "license_compressed_bytes" benchmark. If that was intentional, @stuartmorgan can you rebaseline?

stuartmorgan-g · 2019-08-15T18:46:48Z

It is intentional, but let me do a quick ANGLE roll to pick up https://bugs.chromium.org/p/angleproject/issues/detail?id=3811 before rebaselining since that will substantially reduce the regression.

Rolls buildroot forward to pick up support for building ANGLE. Needed for flutter#9835 Updates license check to ignore a new top-level buildfile-only directory added as part of that support.

stuartmorgan-g · 2019-08-21T17:00:54Z

Closing the loop on license_compressed_bytes, with #11035 we're now just back under the previous baseline target. However, I'll rebase it up slightly so that it won't be a landmine for future small changes.

Alternative Windows shell platform implementation Initial commit.

90235fd

googlebot added the cla: yes label Jul 16, 2019

stuartmorgan-g self-requested a review July 17, 2019 03:58

stuartmorgan-g suggested changes Jul 17, 2019

View reviewed changes

clarkezone added 3 commits July 17, 2019 19:38

Fix TODO switch struct to class and suspend / resume support for plat…

3081296

…form messages

CR feedback

c4dd1bb

CR Feedback

75fd58b

stuartmorgan-g mentioned this pull request Jul 18, 2019

Implement message loop flutter/flutter#36420

Closed

stuartmorgan-g reviewed Jul 18, 2019

View reviewed changes

stuartmorgan-g mentioned this pull request Jul 18, 2019

Add resource context with share group flutter/flutter#36422

Closed

stuartmorgan-g added 2 commits July 18, 2019 15:51

GN format

66f124e

stuartmorgan-g and others added 12 commits July 18, 2019 16:36

Switch to real buildroot

73d70ad

Merge remote-tracking branch 'upstream/master' into nativewindows

df0723e

clang-format

1fd6193

CR feedback

07c3587

CR feedback

e2e85b5

CR feedback

e70105f

CR Feedback

3e04d35

CR Feedback

2905115

CR feedback

c6f5bd7

Merge branch 'master' into nativewindows

8db6e3b

Add support to Windows shell platform for 7d320c4 Add a macro for pre…

fffd7a8

…fixing embedder.h symbols (flutter#9851)

Format happy

77cb2a1

clarkezone commented Jul 28, 2019

View reviewed changes

clarkezone added 3 commits July 28, 2019 05:49

CR feedback

8c3a74d

CR feedback rename FlutterWindow to Win32FlutterWindow

b838153

Fix formatting

5d8998d

Autoformatting

89847a7

stuartmorgan-g added 4 commits August 13, 2019 21:04

Merge branch 'master' into nativewindows

f6c85f0

License files update part 1: flutter

2039ad4

License files update part 2: third_party

495573f

License files update part 3: LICENSE

f06ab12

stuartmorgan-g requested a review from Hixie August 14, 2019 17:41

stuartmorgan-g added 4 commits August 14, 2019 12:20

Merge branch 'master' into nativewindows

cb2919a

Update licenses_third_party signature for merge

208379c

Merge branch 'master' into nativewindows

8bea63c

Signature update for merge again

ed7f45c

stuartmorgan-g added affects: desktop waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Aug 14, 2019

stuartmorgan-g merged commit ff484d4 into flutter:master Aug 14, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2019

ff484d4 [Windows] Alternative Windows shell platform implementation (f…

d106fa8

…lutter/engine#9835)

engine-flutter-autoroll mentioned this pull request Aug 15, 2019

Roll engine c5e30553cd1a..5e155c6c2d35 (5 commits) flutter/flutter#38594

Merged

clarkezone deleted the nativewindows branch August 16, 2019 02:34

clarkezone mentioned this pull request Aug 21, 2019

[Windows] Update API for alternative Windows shell platform implementation #11327

Merged

[Windows] Alternative Windows shell platform implementation #9835

[Windows] Alternative Windows shell platform implementation #9835

Uh oh!

Conversation

clarkezone commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Jul 17, 2019

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g Jul 17, 2019

Choose a reason for hiding this comment

Uh oh!

clarkezone Jul 27, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Jul 18, 2019

Uh oh!

clarkezone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clarkezone Jul 27, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clarkezone commented Aug 7, 2019

Uh oh!

stuartmorgan-g commented Aug 7, 2019

Uh oh!

stuartmorgan-g commented Aug 7, 2019

Uh oh!

stuartmorgan-g commented Aug 7, 2019

Uh oh!

stuartmorgan-g commented Aug 14, 2019

Uh oh!

stuartmorgan-g commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarkezone commented Aug 15, 2019

Uh oh!

stuartmorgan-g commented Aug 15, 2019

Uh oh!

tvolkert commented Aug 15, 2019

Uh oh!

stuartmorgan-g commented Aug 15, 2019

Uh oh!

stuartmorgan-g commented Aug 21, 2019

Uh oh!

clarkezone commented Jul 16, 2019 •

edited

Loading

stuartmorgan-g commented Aug 15, 2019 •

edited

Loading