Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 9, 2019

See #9503 (comment) for context

Fixing both instances where the JNI platform view didn't delegate to the similarly named platform view method.

I could use some help with how to test this.

/cc @abhishekamit

@abhishekamit
Copy link
Contributor

I think the crash caused by #9503 needs to be resolved somehow before this goes in.

Given that that pull request effectively just lowered the cache size from 512mb to 24mb maybe it can be rolled back first?

This change reliably causes an engine crash in release mode for me running hello flutter on a pixel 2.

@dnfield
Copy link
Contributor Author

dnfield commented Jul 10, 2019

What crash is caused by #9503? That patch was landed to fix a crash.

It lowers the default cache size from 512mb (which caused crashes on older iPhones and likely older Androids) to 24, but that value is bumped up to a multiple of the screen size as soon as the resolution is available - which will usually be closer to 50 or so mb. It's still possible to use the message channel to further increase it.

@dnfield
Copy link
Contributor Author

dnfield commented Jul 10, 2019

Ahh I think I see now - the crash is actually when you try to use the method channel. I think those are two separate bugs though.. Rolling back the reduction would re-introduce a different crash and would still leave you with your current crash if you tried to override it.

@dnfield
Copy link
Contributor Author

dnfield commented Jul 10, 2019

I'm going to work on a more comprehensive reland of #9503 - thanks for the pointers here and offline @abhishekamit, I totally missed a few things.

@dnfield dnfield closed this Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants