Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Avoid a full screen overlay within virtual displays" #9581

Merged
amirh merged 1 commit into from
Jun 28, 2019
Merged

Revert "Avoid a full screen overlay within virtual displays" #9581

amirh merged 1 commit into from
Jun 28, 2019

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Jun 28, 2019

Reverts #9343

This caused a regression where the Android webview sizes itself to (0,0) within the VD on certain pages.

Reverting this change, we can re-land after figuring out a solution.

@amirh
Copy link
Contributor Author

amirh commented Jun 28, 2019

@slightfoot

@amirh amirh mentioned this pull request Jun 28, 2019
Closed
mklim
mklim approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh
Copy link
Contributor Author

amirh commented Jun 28, 2019

Landing on red as the breakage was a flake (re-run succeed) but the luci indicator is just not reflecting that.

@amirh amirh merged commit fc1d86b into master Jun 28, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
6374cc1 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
1886842 
…lutter#9343)" (flutter/engine#9581)
This was referenced Jun 29, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
4be695c 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
f6bf380 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
25df75f 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
f702b39 
…lutter#9343)" (flutter/engine#9581)
This was referenced Jun 29, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
d56d9e3 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
ea1ddfc 
…lutter#9343)" (flutter/engine#9581)
This was referenced Jun 29, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
0f64e00 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
fd1af3f 
…lutter#9343)" (flutter/engine#9581)
@slightfoot
Copy link
Member

slightfoot commented Jun 29, 2019

@amirh i'm not sure i follow your last comment. I assume since this ticket has been merged and rolled, the PR is reverted. I'll check into flutter/flutter#35291

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
c302486 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
0e4e012 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
e281c80 
…lutter#9343)" (flutter/engine#9581)
This was referenced Jun 30, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
48848b0 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
f10a950 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
d2bbde6 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
51e90f4 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
4876b5d 
…lutter#9343)" (flutter/engine#9581)
This was referenced Jun 30, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
48e2ae3 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
9fe4505 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
fbd2987 
…lutter#9343)" (flutter/engine#9581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
1084672 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
189ff32 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
040c478 
…lutter#9343)" (flutter/engine#9581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2019
@engine-flutter-autoroll
fc1d86b Revert "Avoid a full screen overlay within virtual displays (f…
09c2e48 
…lutter#9343)" (flutter/engine#9581)
@tvolkert tvolkert deleted the revert-9343-native_ad_fix branch July 1, 2019 16:09
@tvolkert tvolkert mentioned this pull request Jul 1, 2019
Merged
tvolkert added a commit that referenced this pull request Jul 1, 2019
@tvolkert
Cherry-pick fix for flutter/flutter#35291
19e6643 
This cherry-picks the following commit into the `v1.7.8+hotfix.1` branch:

#9581
@tvolkert tvolkert mentioned this pull request Jul 1, 2019
Merged
tvolkert added a commit to flutter/flutter that referenced this pull request Jul 1, 2019
@tvolkert
v1.7.8 hotfixes (#35423)
e40273f 
Cherry-pick the following PRs onto v1.7.8-hotfixes to prepare for release.

flutter/engine#9581
flutter/engine#9464
#35221
KevinG2011 pushed a commit to pepper-ios/flutter that referenced this pull request Apr 23, 2020
@tvolkert
v1.7.8 hotfixes (flutter#35423)
7331489 
Cherry-pick the following PRs onto v1.7.8-hotfixes to prepare for release.

flutter/engine#9581
flutter/engine#9464
flutter#35221
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mklim mklim mklim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amirh @slightfoot @mklim @googlebot