This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support image filter on paint #9508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 26, 2019
Member
Once the UI unit-tests stuff lands, you should be able to snapshot the contents and compare results. |
Contributor
Author
|
@yjbanov is this appropriately done for stub_ui? |
yjbanov
reviewed
Jun 27, 2019
| /// * [MaskFilter], which is used for drawing geometry. | ||
| ImageFilter get imageFilter { | ||
| // TODO(dnfield): Implement ImageFilter | ||
| return null; |
Contributor
There was a problem hiding this comment.
Our approach is to file an issue for known missing Web features. We also typically throw an UnimplementedError, but if this would crash a test, then ignoring this value is fine.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 27, 2019
flutter/engine@f3761ba...0f9e297 git log f3761ba..0f9e297 --no-merges --oneline 0f9e297 Support image filter on paint (flutter/engine#9508) f3ef1bd Roll fuchsia/sdk/core/mac-amd64 from ZZsO1TTl-976ngr5N8h6rRvXTbMO_3qyKDpbeOhE0dwC to C8DMr5XY-F09ZBhT0lbvxOm5MtX3NMmFPKBO6fm40jEC (flutter/engine#9516) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@f3761ba...0f9e297 git log f3761ba..0f9e297 --no-merges --oneline 0f9e297 Support image filter on paint (flutter/engine#9508) f3ef1bd Roll fuchsia/sdk/core/mac-amd64 from ZZsO1TTl-976ngr5N8h6rRvXTbMO_3qyKDpbeOhE0dwC to C8DMr5XY-F09ZBhT0lbvxOm5MtX3NMmFPKBO6fm40jEC (flutter/engine#9516) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#35141
I'm not clear on the best way to test this these days - perhaps a golden test in the framework?