This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix a bug where the platform view's transform is not reset before set frame #9490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 26, 2019
flutter/engine@3f4f606...238fc0f git log 3f4f606..238fc0f --no-merges --oneline 238fc0f Roll src/third_party/skia 9dbbf887cee1..9acfb33ad8c6 (5 commits) (flutter/engine#9505) e4ad3a2 Roll src/third_party/skia 2c1662e24da7..9dbbf887cee1 (6 commits) (flutter/engine#9502) d85599f Roll src/third_party/skia 4f35817f3c91..2c1662e24da7 (3 commits) (flutter/engine#9500) 9190a22 Roll src/third_party/skia a7016ae7f03d..4f35817f3c91 (2 commits) (flutter/engine#9499) 2c8255f Roll src/third_party/skia 01cb2a422884..a7016ae7f03d (5 commits) (flutter/engine#9497) da82361 Purge caches on low memory on iOS (flutter/engine#9491) 3122ecc Roll src/third_party/skia 0c4fbf1bbb93..01cb2a422884 (2 commits) (flutter/engine#9496) 2f1d4f0 fix build breakage on PlatformViews.mm (flutter/engine#9495) 1ab99fb fix a bug where the platform view's transform is not reset before set frame (flutter/engine#9490) aa9b3a1 Reland "IOS Platform view transform/clipping (#9075)" and fix the breakage. (flutter/engine#9483) d90573a Roll src/third_party/skia 69881fb0b5fb..0c4fbf1bbb93 (5 commits) (flutter/engine#9487) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@3f4f606...238fc0f git log 3f4f606..238fc0f --no-merges --oneline 238fc0f Roll src/third_party/skia 9dbbf887cee1..9acfb33ad8c6 (5 commits) (flutter/engine#9505) e4ad3a2 Roll src/third_party/skia 2c1662e24da7..9dbbf887cee1 (6 commits) (flutter/engine#9502) d85599f Roll src/third_party/skia 4f35817f3c91..2c1662e24da7 (3 commits) (flutter/engine#9500) 9190a22 Roll src/third_party/skia a7016ae7f03d..4f35817f3c91 (2 commits) (flutter/engine#9499) 2c8255f Roll src/third_party/skia 01cb2a422884..a7016ae7f03d (5 commits) (flutter/engine#9497) da82361 Purge caches on low memory on iOS (flutter/engine#9491) 3122ecc Roll src/third_party/skia 0c4fbf1bbb93..01cb2a422884 (2 commits) (flutter/engine#9496) 2f1d4f0 fix build breakage on PlatformViews.mm (flutter/engine#9495) 1ab99fb fix a bug where the platform view&flutter#39;s transform is not reset before set frame (flutter/engine#9490) aa9b3a1 Reland &flutter#34;IOS Platform view transform/clipping (flutter#9075)&flutter#34; and fix the breakage. (flutter/engine#9483) d90573a Roll src/third_party/skia 69881fb0b5fb..0c4fbf1bbb93 (5 commits) (flutter/engine#9487) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the view has a transform matrix that is not Identity, setting frame will results a weird behavior to the view's bounds.