This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add --observatory-host switch #9485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts the Dart VM service localhost (::1 / 127.0.0.1) resolution to switches.cc rather than doing it inline when configuring the service isolate.
Adds --observatory-host, which allows callers to specify the localhost IP binding directly. Allows users to set 0.0.0.0 or the host IP address as is possible in the standalone VM, rather than restricting users to loopback. We retain the default behaviour of binding to loopback since the vast majority of observatory use-cases involve local access (e.g. host tests on flutter_tester) or port-forwarded local access (e.g. flutter driver device tests). However, some scenarios, such as QA test labs, may benefit from binding to a publicly-accessible IP address.
Member
Author
|
Fixes flutter/flutter#35079 |
chinmaygarde
approved these changes
Jun 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2019
flutter/engine@ae8e6d9...107fe82 git log ae8e6d9..107fe82 --no-merges --oneline 107fe82 Add --observatory-host switch (flutter/engine#9485) 20a76de Roll src/third_party/skia ebbc82c02471..69881fb0b5fb (11 commits) (flutter/engine#9479) 00d929f Revert "IOS Platform view transform/clipping (#9075)" (flutter/engine#9480) 3390019 fix NPE when a touch event is sent to an unknown Android platform view (flutter/engine#9476) ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075) 13145e9 ios-unit-tests: Started using rsync instead of cp -R to copy frameworks. (flutter/engine#9471) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@ae8e6d9...107fe82 git log ae8e6d9..107fe82 --no-merges --oneline 107fe82 Add --observatory-host switch (flutter/engine#9485) 20a76de Roll src/third_party/skia ebbc82c02471..69881fb0b5fb (11 commits) (flutter/engine#9479) 00d929f Revert &flutter#34;IOS Platform view transform/clipping (flutter#9075)&flutter#34; (flutter/engine#9480) 3390019 fix NPE when a touch event is sent to an unknown Android platform view (flutter/engine#9476) ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075) 13145e9 ios-unit-tests: Started using rsync instead of cp -R to copy frameworks. (flutter/engine#9471) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
creatint
pushed a commit
to creatint/topaz
that referenced
this pull request
Mar 3, 2020
In flutter/engine#9485, support was added for specifying an observatory_host setting (along with the existing Settings::observatory_port) and setting the default host was moved from being hardcoded within the engine to being passed in via settings. This value was initialised in the switches for runners in the engine repo. This applies the same defaulting in flutter_runner. This defaults the value to 127.0.0.1 which matches how it was set implicitly in the past. Long-term this should be passed in as a parameter via e.g. Application::Create() to allow for defaults other than 127.0.0.1. Change-Id: I73ec3044d5590d88212d2f10a280fa52bc8d9cda
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --observatory-host, which allows callers to specify the localhost
IP binding directly. Allows users to set 0.0.0.0 or the host IP address
as is possible in the standalone VM, rather than restricting users to
loopback.
We retain the default behaviour of binding to loopback since the vast
majority of observatory use-cases involve local access (e.g. host tests
on flutter_tester) or port-forwarded local access (e.g. flutter driver
device tests). However, some scenarios, such as QA test labs, may
benefit from binding to a publicly-accessible IP address.