This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Avoid a full screen overlay within virtual displays #9343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just to set the expectations correctly: this isn't fixing the issue of embedding ads as platform views which is broader(the root cause there is the virtual display), we are working with relevant teams on a solution there but it will take time. I'm merging this as I do not see harm in this change, and it's a net improvement if it prevents a false-negative for a specific visibility check of a specific ad provider(again I don't expect that specific ad provider nor the Google Mobile Ads SDK to be properly working with platform views following just this change) |
amirh
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 21, 2019
flutter/engine@3b52992...0c874c6 git log 3b52992..0c874c6 --no-merges --oneline 0c874c6 Avoid a full screen overlay within virtual displays (flutter/engine#9343) 605c63b Roll src/third_party/skia 384981be3dd2..0c64a545176a (11 commits) (flutter/engine#9404) 7a5ec8d Remove build flags for dynamic patching (flutter/engine#9394) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
This was referenced Jun 28, 2019
amirh
added a commit
that referenced
this pull request
Jun 28, 2019
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@3b52992...0c874c6 git log 3b52992..0c874c6 --no-merges --oneline 0c874c6 Avoid a full screen overlay within virtual displays (flutter/engine#9343) 605c63b Roll src/third_party/skia 384981be3dd2..0c64a545176a (11 commits) (flutter/engine#9404) 7a5ec8d Remove build flags for dynamic patching (flutter/engine#9394) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edited by amirh@
Add views that are added directly to a platform view's window as siblings to the platform view's container view, rather than as children of a full screen container.
This prevents a false-negative for a visibility check from a specific ads SDK (Teads), which reported the following warning:
original description
This code is untested. A test build of the engine needs to be created so that commentors of the issue can verify it resolves their ad-display issues.
flutter/flutter#12114