some drive-by docs while I was reading the embedding classes #9341
Conversation
| * <p> | ||
| * A custom Dart entrypoint or Flutter route can also be specified by using an existing {@link | ||
| * FlutterEngine}. A {@link FlutterEngine} can be provided by implementing the | ||
| * {@link #getFlutterEngine} method. Creating a {@link FlutterEngine} before showing a {@code |
There was a problem hiding this comment.
You should probably hold off with this explanation until my current PR is merged. I've renamed this method to provideFlutterEngine because it turns out there were 2 methods called getFlutterEngine for 2 different purposes. I've also made FlutterActivity implement FlutterEngineProvider so that devs no longer have to worry about adding that interface themselves - instead they can just override provideFlutterEngine in their subclass.
There was a problem hiding this comment.
Ya sure, let's get your PR through first.
There was a problem hiding this comment.
@matthew-carroll @xster is the PR in question now merged?
There was a problem hiding this comment.
Yes, the PR was merged. There have also been other non-trivial changes to FlutterActivity so its probably worth re-checking all language in this PR against the latest.
There was a problem hiding this comment.
Cool, I can revise this one at some point this week.
matthew-carroll
left a comment
matthew-carroll
left a comment
There was a problem hiding this comment.
LGTM for Android doc
[email protected]:flutter/engine.git/compare/c5e30553cd1a...5e155c6 git log c5e3055..5e155c6 --no-merges --oneline 2019-08-14 [email protected] some drive-by docs while I was reading the embedding classes (flutter/engine#9341) 2019-08-14 [email protected] Initialize the engine in the running state to match the animator's default state (flutter/engine#11011) 2019-08-14 [email protected] Trace RasterCacheResult::Draw (flutter/engine#11004) 2019-08-14 [email protected] Rename macOS FLE* classes to Flutter* (flutter/engine#11010) 2019-08-14 [email protected] [Windows] Alternative Windows shell platform implementation (flutter/engine#9835) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
4 participants
No description provided.