This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Handle one-way platform messages in the embedder library #9331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 14, 2019
jason-simmons
force-pushed
the
embedder_oneway_message
branch
from
ea2be13 to
338e205
Compare
Messages sent to the embedder host may be one-way messages with no response handler. If the host calls FlutterEngineSendPlatformMessageResponse on a one-way message, then just delete the message response handle. Also update the documentation to indicate that FlutterEngineSendPlatformMessageResponse must be called for all messages. Previously the docs implied that some FlutterPlatformMessage objects may have a null response_handle. The embedder will now set a response_handle for every message (even if the sender does not expect a response).
jason-simmons
force-pushed
the
embedder_oneway_message
branch
from
338e205 to
eecc7ae
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 15, 2019
flutter/engine@2589785...b0757e6 git log 2589785..b0757e6 --no-merges --oneline b0757e6 Roll buildroot to d1bbc14 to pick up fixes for armv7 iOS targets. (flutter/engine#9336) 70ebfc3 Fix the name of the channel parameter in PlatformMessage constructors (flutter/engine#9334) 7283ae3 Handle one-way platform messages in the embedder library (flutter/engine#9331) e8f8a92 Roll buildroot to 75660ad and complete the C++ 17 transition. (flutter/engine#9319) 6d5aaa0 Fix a11y in embedded Android views post O (flutter/engine#9321) f54a8f1 Roll src/third_party/skia c3252a04b377..3fc5df443e24 (1 commits) (flutter/engine#9328) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages sent to the embedder host may be one-way messages with no response
handler. If the host calls FlutterEngineSendPlatformMessageResponse on a
one-way message, then just delete the message response handle.
Also update the documentation to indicate that
FlutterEngineSendPlatformMessageResponse must be called for all messages.
Previously the docs implied that some FlutterPlatformMessage objects may
have a null response_handle. The embedder will now set a response_handle for
every message (even if the sender does not expect a response).