This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Build txt_benchmarks, make benches compile again #9330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 15, 2019
flutter/engine@b0757e6...f44b7b5 git log b0757e6..f44b7b5 --no-merges --oneline f44b7b5 Catch errors during production of kernel dill (flutter/engine#9248) e7853df Roll src/third_party/skia 941b9ff09b25..3721688f64a5 (1 commits) (flutter/engine#9339) c5c0da1 Build txt_benchmarks, make benches compile again (flutter/engine#9330) 46b5c2c Roll src/third_party/skia 3fc5df443e24..941b9ff09b25 (7 commits) (flutter/engine#9333) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables benchmarks for LibTxt, and brings them back in line with modern versions of Skia and LibTxt. This will give us a starting point to compare performance of SkParagraph vs LibTxt and SkShaper vs minikin.
We should add the benchmarks to pre or post submit and track the numbers in the near future.
@Rusino This may be relevant to you! We have not run these benchmarks for a long time, so take any numbers you get with these with a grain of salt.
For reference, originally disabled in #4395 due to windows compatibility