Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Jun 6, 2019

This will catch failure early for cases like #9216 (which fixes manual roll for #8983).

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian merged commit 8eaddd6 into flutter:master Jun 7, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jun 8, 2019
flutter/engine@0602dbb...06dbe28

git log 0602dbb..06dbe28 --no-merges --oneline
06dbe28 Fix instantiateImageCodec api diff with web (stub) (flutter/engine#9234)
99240b7 Remove unnecessary whitelisted flags for --dart-flags (flutter/engine#9233)
8eaddd6 Add web integration test to build_and_test_host (flutter/engine#9218)
a7fb7da Roll src/third_party/dart 9f2f5adb64..6d608fb52b (5 commits)
041c791 Roll src/third_party/skia fe18de506097..14c8ca93db18 (11 commits) (flutter/engine#9231)
086b5a4 move webOnlyScheduleFrameCallback off of window (flutter/engine#9222)
8a6bad6 Roll src/third_party/dart 40ef0c6d9f..9f2f5adb64 (4 commits)
91ee780 Roll src/third_party/skia 6faf8d662af8..fe18de506097 (1 commits) (flutter/engine#9228)
8281919 Roll src/third_party/dart 6e0d978505..40ef0c6d9f (7 commits)
9dafb40 Roll src/third_party/skia 0e8362655a66..6faf8d662af8 (1 commits) (flutter/engine#9225)
e3b8b61 Roll src/third_party/skia 3431d9d1dcc6..0e8362655a66 (2 commits) (flutter/engine#9223)
e80df36 Keyboard support for embedded Android views. (flutter/engine#9203)
2ec6dad Roll src/third_party/skia 6e4fee8c812e..3431d9d1dcc6 (17 commits) (flutter/engine#9221)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2019
@liyuqian liyuqian deleted the test_web branch June 10, 2019 22:15
huqiuser pushed a commit to huqiuser/engine that referenced this pull request Jun 12, 2019
This will catch failure early for cases like flutter#9216 (which fixes manual roll for flutter#8983).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants