Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Switch PlatformViewsController from Activity ref to Application ref." #9211

Merged
amirh merged 1 commit into from
Jun 6, 2019
Merged

Revert "Switch PlatformViewsController from Activity ref to Application ref." #9211

amirh merged 1 commit into from
Jun 6, 2019

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Jun 6, 2019

Reverts #9193

The android_views integration test seems to be broken by this. The issue may be a test bug. Reverting to unblock engine rolls while this is being investigated.

Error log for the failing test:

2019-06-05T19:58:35.230791: stdout: [  +36 ms] E/flutter ( 3001): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: PlatformException(error, Unable to add window -- token null is not for an application, null)
2019-06-05T19:58:35.231018: stdout: [        ] E/flutter ( 3001): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:564:7)
2019-06-05T19:58:35.231307: stdout: [        ] E/flutter ( 3001): #1      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:316:33)
2019-06-05T19:58:35.231499: stdout: [        ] E/flutter ( 3001): 
2019-06-05T19:58:35.231759: stdout: [        ] E/flutter ( 3001): #2      AndroidViewController._create (package:flutter/src/services/platform_views.dart:631:54)
2019-06-05T19:58:35.231959: stdout: [        ] E/flutter ( 3001): 
2019-06-05T19:58:35.232228: stdout: [        ] E/flutter ( 3001): #3      AndroidViewController.setSize (package:flutter/src/services/platform_views.dart:556:14)
2019-06-05T19:58:35.232441: stdout: [        ] E/flutter ( 3001): 
2019-06-05T19:58:35.232660: stdout: [        ] E/flutter ( 3001): #4      RenderAndroidView._sizePlatformView (package:flutter/src/rendering/platform_view.dart:189:29)
2019-06-05T19:58:35.232862: stdout: [        ] E/flutter ( 3001): 
2019-06-05T19:58:35.233109: stdout: [        ] E/flutter ( 3001): #5      RenderAndroidView.performResize (package:flutter/src/rendering/platform_view.dart:170:5)
2019-06-05T19:58:35.233324: stdout: [        ] E/flutter ( 3001): #6      RenderObject.layout (package:flutter/src/rendering/object.dart:1604:9)
2019-06-05T19:58:35.233591: stdout: [        ] E/flutter ( 3001): #7      RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:259:13)
2019-06-05T19:58:35.233781: stdout: [        ] E/flutter ( 3001): #8      RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.234012: stdout: [        ] E/flutter ( 3001): #9      RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:743:15)
2019-06-05T19:58:35.234247: stdout: [        ] E/flutter ( 3001): #10     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.234456: stdout: [        ] E/flutter ( 3001): #11     MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:142:11)
2019-06-05T19:58:35.234618: stdout: [        ] E/flutter ( 3001): #12     _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:443:7)
2019-06-05T19:58:35.234810: stdout: [        ] E/flutter ( 3001): #13     MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:212:7)
2019-06-05T19:58:35.235002: stdout: [        ] E/flutter ( 3001): #14     RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:356:14)
2019-06-05T19:58:35.235178: stdout: [        ] E/flutter ( 3001): #15     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.235363: stdout: [        ] E/flutter ( 3001): #16     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.235552: stdout: [        ] E/flutter ( 3001): #17     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.235981: stdout: [        ] E/flutter ( 3001): #18     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
stdout: [        ] E/flutter ( 3001): #19     _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1214:11)
2019-06-05T19:58:35.236227: stdout: [        ] E/flutter ( 3001): #20     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.236434: stdout: [        ] E/flutter ( 3001): #21     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.236595: stdout: [        ] E/flutter ( 3001): #22     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.236893: stdout: [        ] E/flutter ( 3001): #23     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.237041: stdout: [        ] E/flutter ( 3001): #24     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.237642: stdout: [        ] E/flutter ( 3001): #25     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
stdout: [        ] E/flutter ( 3001): #26     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
stdout: [        ] E/flutter ( 3001): #27     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.237775: stdout: [        ] E/flutter ( 3001): #28     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.237953: stdout: [        ] E/flutter ( 3001): #29     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.238135: stdout: [        ] E/flutter ( 3001): #30     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.238278: stdout: [        ] E/flutter ( 3001): #31     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.238433: stdout: [        ] E/flutter ( 3001): #32     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.238606: stdout: [        ] E/flutter ( 3001): #33     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.238765: stdout: [        ] E/flutter ( 3001): #34     RenderObject.layout (package:flutter/src/rendering/object.dart:1619:7)
2019-06-05T19:58:35.238935: stdout: [        ] E/flutter ( 3001): #35     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
2019-06-05T19:58:35.239141: stdout: [        ] E/flutter ( 3001): #36

@amirh
Copy link
Contributor Author

amirh commented Jun 6, 2019

@zanderso

zanderso
zanderso approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amirh amirh merged commit 647a852 into master Jun 6, 2019
@amirh amirh deleted the revert-9193-switch_platformviewscontroller_from_activity_to_application branch June 6, 2019 16:29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2019
@engine-flutter-autoroll
647a852 Revert "Switch PlatformViewsController from Activity ref to A…
e97d545 
…pplication ref. (flutter#9193)" (flutter/engine#9211)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2019
@engine-flutter-autoroll
647a852 Revert "Switch PlatformViewsController from Activity ref to A…
c5356d5 
…pplication ref. (flutter#9193)" (flutter/engine#9211)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2019
@engine-flutter-autoroll
647a852 Revert "Switch PlatformViewsController from Activity ref to A…
7b1388a 
…pplication ref. (flutter#9193)" (flutter/engine#9211)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2019
Closed
huqiuser pushed a commit to huqiuser/engine that referenced this pull request Jun 12, 2019
@amirh
Revert "Switch PlatformViewsController from Activity ref to Applicati…
0921ac1 
…on ref. (flutter#9193)" (flutter#9211)

This reverts commit 5ea125e.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amirh @zanderso @googlebot