Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Jun 5, 2019

No description provided.

@liyuqian liyuqian requested a review from dnfield June 5, 2019 16:52
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian changed the title Skip golden tess on non-Linux OSes Skip golden tests on non-Linux OSes Jun 5, 2019
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use GTEST_SKIP() in the OS_LINUX guard. That way, the test still gets compiled on the Mac. Just the test is skipped there. Otherwise, folks making changes to the internal API on a Mac will break the build on the bot.

@liyuqian
Copy link
Contributor Author

liyuqian commented Jun 5, 2019

@chinmaygarde : GTEST_SKIP done.

@liyuqian liyuqian merged commit fd4368c into flutter:master Jun 5, 2019
@liyuqian liyuqian deleted the golden_error branch June 5, 2019 21:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jun 6, 2019
flutter/engine@afb9d51...7826548

git log afb9d51..7826548 --no-merges --oneline
7826548 Align fuchsia and non-fuchsia tracing (flutter/engine#9199)
5ea125e Switch PlatformViewsController from Activity ref to Application ref. (flutter/engine#9193)
fd4368c Skip golden tests on non-Linux OSes (flutter/engine#9198)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2019
huqiuser pushed a commit to huqiuser/engine that referenced this pull request Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants