This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix platform views channel regression #9185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2019
Contributor
Author
Contributor
|
Thanks for making that correction @amirh |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2019
flutter/engine@661c24e...86aa014 git log 661c24e..86aa014 --no-merges --oneline 86aa014 Fix platform views channel regression (flutter/engine#9185) bd358e7 Roll src/third_party/skia 806267973f8d..a4bb02063672 (10 commits) (flutter/engine#9184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
This regression was introduced in flutter#7847. The PlatformViewsChannel method call handler was always setting the result to `notImplemented` even after handling a result, this resulted in a "Reply already submitted" exception being thrown. Note that the method channel code is swallowing this exception and logging an error, so we didn't crash instead we were logging an error(this is why the integration test didn't fail). Filed flutter/flutter#33863 to make sure tests fail when such exceptions are thrown. This PR also cleans up an unused `NoSuchPlatformViewException` that was introduced in flutter#7847. flutter/flutter#33866
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression was introduced in #7847.
The PlatformViewsChannel method call handler was always setting the result to
notImplementedeven after handling a result, this resulted in a "Reply already submitted" exception being thrown.Note that the method channel code is swallowing this exception and logging an error, so we didn't crash instead we were logging an error(this is why the integration test didn't fail), sample error that was logged whenever platform views were used on Android:
Filed flutter/flutter#33863 to make sure tests fail when such exceptions are thrown.
This PR also cleans up an unused
NoSuchPlatformViewExceptionthat was introduced in #7847.flutter/flutter#33866